Skip to content

kubevirt: add ReviewTab to CreateVMWizard #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 30, 2019
Merged

kubevirt: add ReviewTab to CreateVMWizard #2567

openshift-merge-robot merged 1 commit into from
Sep 30, 2019

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Sep 3, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Sep 3, 2019
@atiratree
Copy link
Member Author

atiratree commented Sep 3, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2019
@atiratree atiratree mentioned this pull request Sep 3, 2019
Merged
1 task
@atiratree atiratree force-pushed the kubevirt.createVMWizard.review branch from 600d495 to 2dc116c Compare September 18, 2019 12:54
@atiratree atiratree changed the base branch from master to master-4.3 September 18, 2019 12:54
@atiratree atiratree force-pushed the kubevirt.createVMWizard.review branch 3 times, most recently from d0a9c7c to 624527b Compare September 24, 2019 13:42
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@atiratree atiratree changed the base branch from master-4.3 to master September 26, 2019 09:29
@atiratree atiratree force-pushed the kubevirt.createVMWizard.review branch 2 times, most recently from f1e47d8 to 1cb119f Compare September 26, 2019 15:06
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.review branch from 1cb119f to 582ede1 Compare September 27, 2019 12:39
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 27, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.review branch from 582ede1 to 129d444 Compare September 27, 2019 12:43
@atiratree
Copy link
Member Author

atiratree commented Sep 27, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2019
@atiratree
Copy link
Member Author

atiratree commented Sep 27, 2019

/retest

4 similar comments
@atiratree
Copy link
Member Author

atiratree commented Sep 27, 2019

/retest

@atiratree
Copy link
Member Author

atiratree commented Sep 27, 2019

/retest

@atiratree
Copy link
Member Author

atiratree commented Sep 27, 2019

/retest

@atiratree
Copy link
Member Author

atiratree commented Sep 27, 2019

/retest

@atiratree
Copy link
Member Author

atiratree commented Sep 30, 2019

/retest

mareklibra
mareklibra reviewed Sep 30, 2019
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/form/form-field-row.tsx Outdated
Copy link
Contributor

@mareklibra mareklibra Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for better readability, I would implement these two branches as two components.

Copy link
Member Author

@atiratree atiratree Sep 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I created FormFieldReviewRow component but left the other branch intact - because it is a single component and another wrapping layer would not help that much

@atiratree atiratree force-pushed the kubevirt.createVMWizard.review branch from 129d444 to 946aa17 Compare September 30, 2019 09:09
@mareklibra
Copy link
Contributor

mareklibra commented Sep 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8328ada into openshift:master Sep 30, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@mareklibra mareklibra mareklibra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mareklibra mareklibra

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@atiratree @mareklibra @openshift-ci-robot @spadgett @openshift-merge-robot @suomiy