kubevirt: VMWizard - implement footer and the wizard flow #2565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
1 task
atiratree
force-pushed
the
kubevirt.createVMWizard.footer
branch
from
0390676 to
857409e
Compare
atiratree
force-pushed
the
kubevirt.createVMWizard.footer
branch
2 times, most recently
from
269a0f7 to
aae189a
Compare
2 tasks
atiratree
force-pushed
the
kubevirt.createVMWizard.footer
branch
from
aae189a to
8c27d00
Compare
openshift-ci-robot
added
the
approved
atiratree
force-pushed
the
kubevirt.createVMWizard.footer
branch
2 times, most recently
from
aac86b2 to
6d13f66
Compare
openshift-ci-robot
added
size/L
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
rawagner
reviewed
Sep 27, 2019
Contributor
rawagner
left a comment
rawagner
left a comment
There was a problem hiding this comment.
just two nitpicks, not blocking
Contributor
There was a problem hiding this comment.
Suggested change
| createVmText: string; | |
| createVMText: string; |
Contributor
There was a problem hiding this comment.
Suggested change
| createVmText, | |
| createVMText, |
Contributor
|
/approve |
Contributor
|
/lgtm |
- buttons, jumps
atiratree
force-pushed
the
kubevirt.createVMWizard.footer
branch
from
6d13f66 to
77a641f
Compare
Member
Author
|
fixed |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on:
implement logic (disabling, jumps) for buttons and nav list