-
Notifications
You must be signed in to change notification settings - Fork 150
OCPBUGS-57129: Add missing Console capability annotation #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jhadvig: This pull request references Jira Issue OCPBUGS-57129, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
lgtm |
TheRealJon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| include.release.openshift.io/ibm-cloud-managed: "true" | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
| capability.openshift.io/name: Console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add this annotation to include.release.openshift.io/hypershift cluster-profile manifests, because openshift/hypershift#6183 is still in flight trying to make "HyperShift clusters with Console disabled" an option.
However, this particular manifest also belongs to other cluster profiles, like the default include.release.openshift.io/self-managed-high-availability. You cannot add the Console capability annotation to those, because there are already self-managed-high-availability clusters with the Console disabled and the cluster-version operator actively managing this resource. Upon update, the CVO will implicitly enable the Console capability, to avoid orphaning that resource. There's OTA-1039 thinking that some day, we might grow some kind of knob to work around that, but there hasn't been enough interest to get it prioritized. So for today's CVO, you'd need to shard this manifest into two:
- One for cluster profiles like
include.release.openshift.io/hypershiftwhere you knew there couldn't be anyConsole-less clusters yet, where you could add thisConsoleannotation. - Another for cluster profiles like
include.release.openshift.io/self-managed-high-availabilitywhere there might be existingConsole-less clusters, where you need to either live with the presence of the resource on clusters withoutConsoleenabled, or find some other workaround.
Also in this space, the include.release.openshift.io/single-node-developer profile was abandoned, so you can drop that (e.g. see openshift/cluster-version-operator#685)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to just focus on the Deployment in this pull, and have this StorageVersionMigration manifest be part of OCPBUGS-57055.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi :) why was it decided to merge this PR with this change?
Aren’t we agreed it's needed to keep the profiles separate?
|
/jira refresh |
|
@jhadvig: This pull request references Jira Issue OCPBUGS-57129, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jhadvig: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jhadvig: Jira Issue OCPBUGS-57129: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-57129 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console-operator |
/assign @wking
@linoyaslan FYI