Skip to content

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Jun 11, 2025

/assign @wking

@linoyaslan FYI

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 11, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-57129, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/assign @wking

@linoyaslan FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and spadgett June 11, 2025 16:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@enxebre
Copy link
Member

enxebre commented Jun 12, 2025

lgtm

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
include.release.openshift.io/single-node-developer: "true"
capability.openshift.io/name: Console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add this annotation to include.release.openshift.io/hypershift cluster-profile manifests, because openshift/hypershift#6183 is still in flight trying to make "HyperShift clusters with Console disabled" an option.

However, this particular manifest also belongs to other cluster profiles, like the default include.release.openshift.io/self-managed-high-availability. You cannot add the Console capability annotation to those, because there are already self-managed-high-availability clusters with the Console disabled and the cluster-version operator actively managing this resource. Upon update, the CVO will implicitly enable the Console capability, to avoid orphaning that resource. There's OTA-1039 thinking that some day, we might grow some kind of knob to work around that, but there hasn't been enough interest to get it prioritized. So for today's CVO, you'd need to shard this manifest into two:

  • One for cluster profiles like include.release.openshift.io/hypershift where you knew there couldn't be any Console-less clusters yet, where you could add this Console annotation.
  • Another for cluster profiles like include.release.openshift.io/self-managed-high-availability where there might be existing Console-less clusters, where you need to either live with the presence of the resource on clusters without Console enabled, or find some other workaround.

Also in this space, the include.release.openshift.io/single-node-developer profile was abandoned, so you can drop that (e.g. see openshift/cluster-version-operator#685)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to just focus on the Deployment in this pull, and have this StorageVersionMigration manifest be part of OCPBUGS-57055.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) why was it decided to merge this PR with this change?
Aren’t we agreed it's needed to keep the profiles separate?

@jhadvig
Copy link
Member Author

jhadvig commented Jun 16, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 16, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-57129, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei June 16, 2025 12:50
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c005930 and 2 for PR HEAD b200512 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2025

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f2050d2 into openshift:main Jun 16, 2025
12 checks passed
@openshift-ci-robot
Copy link
Contributor

@jhadvig: Jira Issue OCPBUGS-57129: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57129 has been moved to the MODIFIED state.

Details

In response to this:

/assign @wking

@linoyaslan FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.20.0-202506161812.p0.gf2050d2.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants