-
Notifications
You must be signed in to change notification settings - Fork 429
MGMT-20771: Enable disabling of Console capability #6183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-20771: Enable disabling of Console capability #6183
Conversation
|
@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6197c5a to
0c8a121
Compare
fc50b9c to
46aa411
Compare
054418e to
c6dc38c
Compare
|
@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
c6dc38c to
2ead0fa
Compare
|
Let's update the PR to include support for only one new capability. Then please let's add e2e validation for it within TestCreateClusterCustomConfig, see EnsureImageRegistryCapabilityDisabled as an example. These capabilities should be more straight forward if they don't have management side implications |
Test Resultse2e-aws
Failed TestsTotal failed tests: 2
e2e-aks
|
|
@linoyaslan: This pull request references MGMT-20771 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/unhold |
|
/hold Revision e290041 was retested 3 times: holding |
|
/test e2e-aws |
|
/unhold |
e290041 to
09301e4
Compare
This commit is part of expanding support for disabling openshift capabilities in hypershift. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates. Note: OCPBUGS-57055 is a UX issue. Since the problem is limited to non-functional CRDs appearing, there’s no straightforward fix, and this behavior is already a known limitation in standalone OpenShift, it was decided not to block the “disable console” functionality in HyperShift because of it.
09301e4 to
742ac94
Compare
|
/lgtm |
|
/test e2e-aks |
|
/override "Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main" |
|
@enxebre: Overrode contexts on behalf of enxebre: Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main, Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@linoyaslan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
97de00b
into
openshift:main
What this PR does / why we need it:
This PR is part of expanding support for disabling openshift capabilities in hypershift. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.
NOTE: OCPBUGS-57055 is a UX issue. Since the problem is limited to non-functional CRDs appearing, there’s no straightforward fix, and this behavior is already a known limitation in standalone OpenShift, it was decided not to block the “disable console” functionality in HyperShift because of it.
Checklist