OCPBUGS-18454: Avoid using risk names as condition reasons when invalid

[petr-muller]

Until / unless we merge openshift/api#1577, conditional risk names may not be valid condition reason strings, so we need to check them and use a generic (new RiskAppliesToCluster) reason instead.

I took the opportunity and wrote tests and refactored the code slightly (make it easily testable from a single place and get rid of extensive branching logic that was hard to read). I suggest reviewing individual commits.

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-9050, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Until / unless we merge openshift/api#1577, conditional risk names may not be valid condition reason strings, so we need to check them and use a generic (new RiskAppliesToCluster) reason instead.

I took the opportunity and wrote tests and refactored the code slightly (make it easily testable from a single place and get rid of extensive branching logic that was hard to read).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-9050, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Until / unless we merge openshift/api#1577, conditional risk names may not be valid condition reason strings, so we need to check them and use a generic (new RiskAppliesToCluster) reason instead.

I took the opportunity and wrote tests and refactored the code slightly (make it easily testable from a single place and get rid of extensive branching logic that was hard to read). I suggest reviewing individual commits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-18454, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Until / unless we merge openshift/api#1577, conditional risk names may not be valid condition reason strings, so we need to check them and use a generic (new RiskAppliesToCluster) reason instead.

I took the opportunity and wrote tests and refactored the code slightly (make it easily testable from a single place and get rid of extensive branching logic that was hard to read). I suggest reviewing individual commits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[petr-muller]

/hold

Reviews welcome but this will need to be adapted to #964 which is more important to merge.

[petr-muller]

/jira refresh

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-18454, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @shellyyang1989

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[petr-muller]

#964 merged but not this PR needs to wait for #939 and #961 to avoid conflicts

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[petr-muller]

/remove-lifecycle stale

[petr-muller]

@LalatenduMohanty @wking addressed reviews, PTAL

[petr-muller]

/hold cancel

[LalatenduMohanty]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [LalatenduMohanty,petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[petr-muller]

/retest

[petr-muller]

: [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers
{  event [namespace/openshift-console node/ci-op-icws625r-deec6-675nt-master-2 pod/console-6c8659cb4-5ffv7 hmsg/385654efc2 - Back-off restarting failed container console in pod console-6c8659cb4-5ffv7_openshift-console(f816a379-3140-4d58-9975-1a21d6954f0b)] happened 53 times}

Does not seem related
/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

[openshift-ci]

@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-ovn-upgrade-into-change

Details

In response to this:

: [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers
{  event [namespace/openshift-console node/ci-op-icws625r-deec6-675nt-master-2 pod/console-6c8659cb4-5ffv7 hmsg/385654efc2 - Back-off restarting failed container console in pod console-6c8659cb4-5ffv7_openshift-console(f816a379-3140-4d58-9975-1a21d6954f0b)] happened 53 times}

Does not seem related
/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shellyyang1989]

/label qe-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2f1f8d6 and 2 for PR HEAD 71c5a68 in total

[openshift-ci]

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@petr-muller: Jira Issue OCPBUGS-18454: All pull requests linked via external trackers have merged:

• openshift/cincinnati-graph-data#4059
• openshift/cluster-version-operator#962

Jira Issue OCPBUGS-18454 has been moved to the MODIFIED state.

Details

In response to this:

Until / unless we merge openshift/api#1577, conditional risk names may not be valid condition reason strings, so we need to check them and use a generic (new RiskAppliesToCluster) reason instead.

I took the opportunity and wrote tests and refactored the code slightly (make it easily testable from a single place and get rid of extensive branching logic that was hard to read). I suggest reviewing individual commits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-version-operator-container-v4.16.0-202401272017.p0.ga679864.assembly.stream for distgit cluster-version-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-01-31-073538