validate-blocked-edges.py: enforce CamelCase names

[petr-muller]

When testing openshift/cluster-version-operator#961 I have seen CVO choking on incorrect mocked data because we assign the name of the risk to a condition.Reason directly:

- lastTransitionTime: "2023-08-30T10:19:05Z"
  message: 'ClusterVersion.config.openshift.io "version" is invalid: status.conditionalUpdates[1].conditions[0].reason:
    Invalid value: "OCBBUGS-13308-01": status.conditionalUpdates[1].conditions[0].reason
    in body should match ''^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$'''
  status: "True"
  type: Failing

It seems we never actually tripped this in the past but there is no reason why our checks should not protect us from that.

xref: OCPBUGS-18454

[petr-muller]

/test all

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[petr-muller]

/retest

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-18454, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When testing openshift/cluster-version-operator#961 I have seen CVO choking on incorrect mocked data because we assign the name of the risk to a condition.Reason directly:

- lastTransitionTime: "2023-08-30T10:19:05Z"
 message: 'ClusterVersion.config.openshift.io "version" is invalid: status.conditionalUpdates[1].conditions[0].reason:
   Invalid value: "OCBBUGS-13308-01": status.conditionalUpdates[1].conditions[0].reason
   in body should match ''^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$'''
 status: "True"
 type: Failing

It seems we never actually tripped this in the past but there is no reason why our checks should not protect us from that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[petr-muller]

/hold
Thanks for the review, will address!

[openshift-ci-robot]

@petr-muller: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

When testing openshift/cluster-version-operator#961 I have seen CVO choking on incorrect mocked data because we assign the name of the risk to a condition.Reason directly:

- lastTransitionTime: "2023-08-30T10:19:05Z"
 message: 'ClusterVersion.config.openshift.io "version" is invalid: status.conditionalUpdates[1].conditions[0].reason:
   Invalid value: "OCBBUGS-13308-01": status.conditionalUpdates[1].conditions[0].reason
   in body should match ''^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$'''
 status: "True"
 type: Failing

It seems we never actually tripped this in the past but there is no reason why our checks should not protect us from that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[petr-muller]

/hold cancel

[openshift-ci]

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-01-31-073538