Skip to content

OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
May 4, 2023
Merged

OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB #931

openshift-merge-robot merged 3 commits into from
May 4, 2023

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Apr 20, 2023

This is a cherry-pick of #923

The 8af3ba9 commit did not apply cleanly and I had to manually adjust for missing #839 and #860, but the changes were not that invasive, so I do not consider the resulting change to be too risky compared to #923

@deads2k @petr-muller
Update dnsPolicy to allow consistent resolution of the internal LB
5602fa1 
The kubelet consistently resolves the name.  This change allows the CVO
to use the kubelet's DNS configuration.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

@petr-muller: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Update dnsPolicy to allow consistent resolution of the internal LB

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-muller
Copy link
Member Author

petr-muller commented Apr 20, 2023

/jira cherrypick OCPBUGS-11435

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2023

@petr-muller: Jira Issue OCPBUGS-11435 has been cloned as Jira Issue OCPBUGS-12182. Will retitle bug to link to clone.
/retitle OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB

Details

In response to this:

/jira cherrypick OCPBUGS-11435

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title Update dnsPolicy to allow consistent resolution of the internal LB OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB Apr 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2023

@petr-muller: This pull request references Jira Issue OCPBUGS-12182, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11435 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a cherry-pick of #923

The 8af3ba9 commit did not apply cleanly and I had to manually adjust for missing #839 and #860, but the changes were not that invasive, so I do not consider the resulting change to be too risky compared to #923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

@petr-muller: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deads2k added 2 commits April 20, 2023 13:30
@deads2k @petr-muller
replace global clustercondition registry with instance based approach
89c986f 
Globals cause problems for unit tests (demonstrated in some of the unit
tests) and prevent general reuse.  The anti-pattern is avoided in
kuberentes code and should be OCP as well.  This updates to providing a
configured condition registry without init blocks and provides a
standard clustercondition registry for each consumption.
@deads2k @petr-muller
connect to thanos using IP
f9659cc 
We do this so that our host-network pod can use the node's resolv.conf to resolve the internal load balancer name
on the pod before DNS pods are available and before the service network is available.  The side effect is that
the CVO cannot resolve service DNS names.
@petr-muller petr-muller force-pushed the cherry-pick-920-to-release-4.12 branch from 13e9d86 to f9659cc Compare April 20, 2023 11:31
@petr-muller
Copy link
Member Author

petr-muller commented Apr 20, 2023

TestCVO_UpgradeFailedPayloadLoadWithCapsChanges flake was only fixed in 4.13
/test unit

@petr-muller
Copy link
Member Author

petr-muller commented Apr 20, 2023

/retest

All failures seem unrelated

@petr-muller
Copy link
Member Author

petr-muller commented Apr 21, 2023

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2023

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member Author

petr-muller commented Apr 28, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 28, 2023

@petr-muller: This pull request references Jira Issue OCPBUGS-12182, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11435 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-11435 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jiajliu April 28, 2023 10:17
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented May 2, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 2, 2023
LalatenduMohanty
LalatenduMohanty approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@petr-muller
Copy link
Member Author

petr-muller commented May 3, 2023

@jianlinliu @jiajliu PTAL for cherry-pick-approved

@evakhoni
Copy link
Contributor

evakhoni commented May 3, 2023

/uncc @jiajliu
/cc @shellyyang1989

@openshift-ci openshift-ci bot requested review from shellyyang1989 and removed request for jiajliu May 3, 2023 16:02
@shellyyang1989
Copy link
Contributor

shellyyang1989 commented May 4, 2023

/label qe-approved

as pre-merge test passed

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 4, 2023
@jianlinliu
Copy link

jianlinliu commented May 4, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit f2620f6 into openshift:release-4.12 May 4, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 4, 2023

@petr-muller: Jira Issue OCPBUGS-12182: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12182 has been moved to the MODIFIED state.

Details

In response to this:

This is a cherry-pick of #923

The 8af3ba9 commit did not apply cleanly and I had to manually adjust for missing #839 and #860, but the changes were not that invasive, so I do not consider the resulting change to be too risky compared to #923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented May 5, 2023

Fix included in accepted release 4.12.0-0.nightly-2023-05-05-162250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking Awaiting requested review from wking

@shellyyang1989 shellyyang1989 Awaiting requested review from shellyyang1989

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@petr-muller @openshift-ci-robot @LalatenduMohanty @evakhoni @shellyyang1989 @jianlinliu @openshift-merge-robot @deads2k