pkg/cincinnati: Set User-Agent for Cincinnati requests

[wking]

So that it's easier to guess at the fraction of requests that are CVOs vs. other clients. I'd like to set this for our signature requests too (vendor/github.com/openshift/library-go/pkg/verify/store/sigstore), but that would take some library-go requests first.

[wking]

I tested this in cluster bot with launch 4.12.0-0.nightly-2022-09-19-161258,openshift/cluster-version-operator#839 gcp, set channel, and pointed ClusterVersion's spec.upstream at the invalid https://api.stage.openshift.com/api/upgrades_info/wking-cvo-839. That gave logs like:

$ oc -n cincinnati-stage get -o name pods | while read POD; do oc -n cincinnati-stage logs -c cincinnati-policy-engine "${POD}" | grep wking; done
[2022-09-19T23:03:09Z ERROR policy_engine] Error serving request 'Method: 'GET', Request: '/api/upgrades_info/wking-cvo-839', Query: 'arch=amd64&channel=wking-cvo-839&id=d9d35431-c35b-4425-bb47-35001cc4da70&version=4.12.0-ec.3', User-Agent: 'Go-http-client/1.1', Accept: 'application/json'' from '10.131.28.30:53010': Incorrect Endpoint
[2022-09-19T23:05:57Z ERROR policy_engine] Error serving request 'Method: 'GET', Request: '/api/upgrades_info/wking-cvo-839', Query: 'arch=amd64&channel=wking-cvo-839&id=d9d35431-c35b-4425-bb47-35001cc4da70&version=4.12.0-ec.3', User-Agent: 'Go-http-client/1.1', Accept: 'application/json'' from '10.131.28.30:35020': Incorrect Endpoint
[2022-09-19T23:07:54Z ERROR policy_engine] Error serving request 'Method: 'GET', Request: '/api/upgrades_info/wking-cvo-839', Query: 'arch=amd64&channel=wking-cvo-839&id=d9d35431-c35b-4425-bb47-35001cc4da70&version=0.0.1-0.test-2022-09-19-221623-ci-ln-l86zy4b-latest', User-Agent: 'ClusterVersionOperator/1.0.0-899-ge3101963-dirty', Accept: 'application/json'' from '10.131.28.30:34674': Incorrect Endpoint

As I updated back and forth between 4.12.0-ec.3 and the cluster-bot-built commit to check the behavior vs. the current dev branch. It shows my change improving the User-Agent from ec.3's Go-http-client/1.1 to my PR's ClusterVersionOperator/1.0.0-899-ge3101963-dirty. With ART builds, we'll get the same version number they compile us with, like:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-serial/1570267348072402944/artifacts/e2e-aws-sdn-serial/gather-extra/artifacts/pods/openshift-cluster-version_cluster-version-operator-7789fd6cc6-gknjr_cluster-version-operator.log | head -n1
I0915 04:53:34.063931       1 start.go:23] ClusterVersionOperator 4.12.0-202209132338.p0.g583c3e2.assembly.stream-583c3e2

for 4.12.0-ec.3.

[wking]

/retest

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[wking]

Rebased onto master with 7d0e9bd -> 1dd2378.

/remove-lifecycle stale

[petr-muller]

/retest

[petr-muller]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d3a03ab and 2 for PR HEAD 1dd2378 in total

[openshift-ci]

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.