Skip to content

[WIP] Library go bump test#720

Closed
qJkee wants to merge 6 commits intoopenshift:masterfrom
qJkee:library_go_bump_test
Closed

[WIP] Library go bump test#720
qJkee wants to merge 6 commits intoopenshift:masterfrom
qJkee:library_go_bump_test

Conversation

@qJkee
Copy link
Copy Markdown
Contributor

@qJkee qJkee commented Dec 29, 2021

No description provided.

eggfoobar and others added 6 commits December 30, 2021 01:40
bumped library-go to latest
updated lib core.go to use new ProbeHandler names introduced by update

Signed-off-by: ehila <ehila@redhat.com>
leader election can now be topology aware and driven from library-go with configs based on conventions

Signed-off-by: ehila <ehila@redhat.com>

fix: update unit test for unexported Manifest field

Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
updated library-go to latest for fix in pr openshift/library-go#1273

Signed-off-by: ehila <ehila@redhat.com>
fixed e2e test by adding the leader election option to the constructed options struct

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qJkee
To complete the pull request process, please assign lalatendumohanty after the PR has been reviewed.
You can assign the PR to them by writing /assign @lalatendumohanty in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Dec 30, 2021

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 30, 2021

@qJkee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-upgrade 02cc6a3 link true /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Copy Markdown

vrutkovs commented Jan 3, 2022

Dupe of #716?

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 8, 2022

@qJkee: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qJkee qJkee closed this Jan 10, 2022
@qJkee qJkee deleted the library_go_bump_test branch January 10, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants