Bug 2030628: [release-4.7] Respect noProxy #711
Conversation
Since 4.2's ea5e3bc (Add http transport for cincinnati to enable proxy, 2019-07-16, openshift#219), the CVO has been consuming httpsProxy, but not httpProxy or noProxy [1]. This commit fixes that. I'm handing off the logic that mixes those three together to pick the proxy URI to the httpproxy library, which is also what the Go standard library uses for this purpose. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1978749 Cherry-pick of: e43080d
Generated with: $ go mod vendor $ go mod tidy using: $ go version go version go1.15.15 linux/amd64
Signed-off-by: Arjun Naik <[email protected]>
Signed-off-by: Arjun Naik <[email protected]>
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
@palonsoro: This pull request references Bugzilla bug 2030628, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
requested review from
LalatenduMohanty,
jianlinliu and
wking
|
/test all |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@palonsoro: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @LalatenduMohanty |
|
/label backport-risk-assessed |
openshift-ci
bot
added
backport-risk-assessed
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
Hi. Can this PR be reviewed and merged? Is anything else pending to do so? |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
$ cherry-pick-diff origin/release-4.7..origin/pr/711 origin/release-4.8
ee66c8a2 -> 18d5957d Fixed the cluster version update verify function
91794f06 -> bcf18a02 Fixed fake client for CVO scenarios test
cdca0adc -> c75e3279 vendor: Include golang.org/x/net/http/httpproxy
da191270 -> a114d6d6 pkg/cvo: Respect noProxy
...just context changes for the three non-vendor picks, and then a bunch of divergence on the httpproxy bump...which is a clean enough set of backports for me. All four commits are part of #691.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, palonsoro, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@palonsoro: All pull requests linked via external trackers have merged: Bugzilla bug 2030628 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
PR to backport #622 to release-4.7. It consists of: