Bug 1982683: [release-4.8] Respect noProxy #691

palonsoro · 2021-11-15T13:23:10Z

PR to backport #622 to release-4.8. It consists of:

Cherry-picking da19127
Vendoring golang.org/x/net/http/httpproxy
Also cherry-picking da19127 and ee66c8a in order to backport some fixes made to CVO scenarios tests. The failures fixed at those commits seemed to impact the CVO scenarios test once da19127 was backported and httpproxy was vendored.

Since 4.2's ea5e3bc (Add http transport for cincinnati to enable proxy, 2019-07-16, openshift#219), the CVO has been consuming httpsProxy, but not httpProxy or noProxy [1]. This commit fixes that. I'm handing off the logic that mixes those three together to pick the proxy URI to the httpproxy library, which is also what the Go standard library uses for this purpose. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1978749 Cherry-pick of: e43080d

Generated with: $ go mod vendor $ go mod tidy using: $ go version go version go1.16.8 linux/arm64

Signed-off-by: Arjun Naik <[email protected]>

openshift-ci · 2021-11-15T13:23:19Z

@palonsoro: This pull request references Bugzilla bug 1982683, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1978749 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1978749 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0, 4.9.z
bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

Bug 1982683: Respect noProxy [4.8.z backport]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-15T13:24:11Z

@palonsoro: This pull request references Bugzilla bug 1982683, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1978749 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1978749 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0, 4.9.z
bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

Bug 1982683: Respect noProxy [4.8.z backport]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-15T13:24:36Z

@palonsoro: This pull request references Bugzilla bug 1982683, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1978749 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1978749 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0, 4.9.z
bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

Bug 1982683: Respect noProxy [4.8.z backport]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

palonsoro · 2021-11-15T15:12:07Z

/retest

vrutkovs · 2021-11-15T15:18:27Z

/retitle Bug 1982683: [release-4.8] Respect noProxy
/approve

LalatenduMohanty · 2021-11-15T22:17:41Z

/label backport-risk-assessed

LalatenduMohanty · 2021-11-15T22:17:54Z

/test e2e-agnostic

LalatenduMohanty · 2021-11-15T22:18:10Z

/test e2e-agnostic-upgrade

palonsoro · 2021-11-16T09:01:07Z

/test e2e-agnostic-upgrade

palonsoro · 2021-11-16T12:58:39Z

/retest

palonsoro · 2021-11-16T16:53:07Z

/retest

palonsoro · 2021-11-16T17:42:29Z

/retest

palonsoro · 2021-11-17T14:34:46Z

/retest

palonsoro · 2021-11-17T18:33:14Z

/retest

vrutkovs

/lgtm

jiajliu · 2021-11-23T08:24:42Z

/lgtm
/label qe-approved

openshift-ci · 2021-11-23T08:27:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiajliu, palonsoro, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianlinliu · 2021-11-25T02:19:16Z

/label cherry-pick-approved

openshift-bot · 2021-11-25T03:48:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-25T07:02:13Z

@palonsoro: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#691

Bugzilla bug 1982683 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1982683: [release-4.8] Respect noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking and others added 4 commits November 12, 2021 10:08

vendor: Include golang.org/x/net/http/httpproxy

cdca0ad

Generated with: $ go mod vendor $ go mod tidy using: $ go version go version go1.16.8 linux/arm64

Fixed fake client for CVO scenarios test

91794f0

Signed-off-by: Arjun Naik <[email protected]>

Fixed the cluster version update verify function

ee66c8a

Signed-off-by: Arjun Naik <[email protected]>

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 15, 2021

openshift-ci bot requested a review from jianlinliu November 15, 2021 13:23

openshift-ci bot requested review from jottofar and vrutkovs November 15, 2021 13:24

openshift-ci bot changed the title ~~Bug 1982683: Respect noProxy [4.8.z backport]~~ Bug 1982683: [release-4.8] Respect noProxy Nov 15, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 15, 2021

vrutkovs approved these changes Nov 22, 2021

View reviewed changes

openshift-ci bot assigned vrutkovs Nov 22, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2021

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 23, 2021

openshift-ci bot assigned jiajliu Nov 23, 2021

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 25, 2021

openshift-merge-robot merged commit 887cf90 into openshift:release-4.8 Nov 25, 2021

Bug 1982683: [release-4.8] Respect noProxy #691

Bug 1982683: [release-4.8] Respect noProxy #691

Uh oh!

Conversation

palonsoro commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Nov 15, 2021

Uh oh!

openshift-ci bot commented Nov 15, 2021

Uh oh!

openshift-ci bot commented Nov 15, 2021

Uh oh!

palonsoro commented Nov 15, 2021

Uh oh!

vrutkovs commented Nov 15, 2021

Uh oh!

LalatenduMohanty commented Nov 15, 2021

Uh oh!

LalatenduMohanty commented Nov 15, 2021

Uh oh!

LalatenduMohanty commented Nov 15, 2021

Uh oh!

palonsoro commented Nov 16, 2021

Uh oh!

palonsoro commented Nov 16, 2021

Uh oh!

palonsoro commented Nov 16, 2021

Uh oh!

palonsoro commented Nov 16, 2021

Uh oh!

palonsoro commented Nov 17, 2021

Uh oh!

palonsoro commented Nov 17, 2021

Uh oh!

vrutkovs left a comment

Choose a reason for hiding this comment

Uh oh!

jiajliu commented Nov 23, 2021

Uh oh!

openshift-ci bot commented Nov 23, 2021

Uh oh!

jianlinliu commented Nov 25, 2021

Uh oh!

openshift-bot commented Nov 25, 2021

Uh oh!

openshift-ci bot commented Nov 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

palonsoro commented Nov 15, 2021 •

edited

Loading