Skip to content

hack/generate-lib-resources: Use library-go manifests #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 1, 2021
Merged

hack/generate-lib-resources: Use library-go manifests #552

openshift-merge-robot merged 1 commit into from
Jun 1, 2021

Conversation

@wking
Copy link
Member

@wking wking commented May 4, 2021

Catching the generator up with ce2874f (#443).

@wking
hack/generate-lib-resources: Use library-go manifests
93b1cc9 
Catching the generator up with ce2874f (Modify to use library-go
manifest and verify packages, 2020-08-25, openshift#443).
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@wking wking mentioned this pull request May 13, 2021
Merged
2 tasks
@vrutkovs
Copy link

vrutkovs commented May 31, 2021

/retest

1 similar comment
@vrutkovs
Copy link

vrutkovs commented May 31, 2021

/retest

vrutkovs
vrutkovs approved these changes May 31, 2021
View reviewed changes
Copy link

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented May 31, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented May 31, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking wking added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 1, 2021
@wking
Copy link
Member Author

wking commented Jun 1, 2021

Twiddling the bug label, because this just catches the generator up with the existing code, and that's not user-facing.

@openshift-merge-robot openshift-merge-robot merged commit 1706169 into openshift:master Jun 1, 2021
@wking wking deleted the generate-lib-resources-library-go-manifest branch June 1, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @openshift-ci-robot @vrutkovs @openshift-bot @openshift-merge-robot