Modify to use library-go manifest and verify packages #443

jottofar · 2020-08-25T15:55:53Z

library-go manifest and verify packages were created since both CVO and the oc client use them.

jottofar · 2020-08-25T16:36:36Z

/test unit

jottofar · 2020-08-25T19:18:14Z

/retest

pkg/cvo/cvo.go

jottofar · 2020-08-31T18:09:23Z

/retest

jottofar · 2020-09-07T23:15:42Z

/retest

jottofar · 2020-09-07T23:17:40Z

/bugzilla refresh

openshift-ci-robot · 2020-09-07T23:17:41Z

@jottofar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jottofar · 2020-09-16T14:49:29Z

/bugzilla refresh

openshift-ci-robot · 2020-09-16T14:49:31Z

@jottofar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jottofar · 2020-09-16T19:53:14Z

/bugzilla refresh

openshift-ci-robot · 2020-09-16T19:53:16Z

@jottofar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-06T13:37:19Z

@jottofar: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/unit	`f23ecf6`	link	`/test unit`
ci/prow/gofmt	`f23ecf6`	link	`/test gofmt`
ci/prow/integration	`f23ecf6`	link	`/test integration`
ci/prow/e2e	`f23ecf6`	link	`/test e2e`
ci/prow/images	`f23ecf6`	link	`/test images`
ci/prow/e2e-upgrade	`f23ecf6`	link	`/test e2e-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jottofar · 2020-10-23T13:39:07Z

/retest

jottofar · 2020-10-27T13:42:49Z

/retest

pkg/cvo/cvo_test.go

Steps: $ go get github.com/openshift/library-go $ go mod tidy $ go mod vendor using: $ go version go version go1.15.3 linux/amd64

library-go manifest and verify packages were created since both CVO and the oc client use them.

jottofar · 2020-11-18T14:22:41Z

/retest

jottofar · 2020-11-18T15:04:37Z

/test integration

jottofar · 2020-11-18T19:12:09Z

/retest

jottofar · 2020-11-18T23:13:56Z

/retest

wking · 2020-12-05T04:59:23Z

/test e2e-agnostic

wking · 2020-12-06T05:42:38Z

Integration is still blocked on openshift/release#13745 or similar.

/override ci/prow/integration

/lgtm

openshift-ci-robot · 2020-12-06T05:42:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-12-06T05:42:59Z

@wking: Overrode contexts on behalf of wking: ci/prow/integration

Details

In response to this:

Integration is still blocked on openshift/release#13745 or similar.

/override ci/prow/integration

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-06T07:53:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T08:06:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T08:45:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T08:58:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T09:37:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T09:50:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T11:34:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T11:47:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T13:31:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T14:10:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot · 2020-12-06T14:59:10Z

@jottofar: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e	`a2ae4fe`	link	`/test e2e`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-12-06T15:02:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T16:07:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Catching the generator up with ce2874f (Modify to use library-go manifest and verify packages, 2020-08-25, openshift#443).

openshift-ci-robot requested review from abhinavdahiya and crawford August 25, 2020 15:56

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020

jottofar force-pushed the ota-190-library-go-reuse branch from c583ff1 to f0004e9 Compare August 25, 2020 16:02

jottofar force-pushed the ota-190-library-go-reuse branch from f0004e9 to e159773 Compare August 25, 2020 18:58

jottofar force-pushed the ota-190-library-go-reuse branch 2 times, most recently from e159773 to 491e499 Compare August 26, 2020 18:59

wking reviewed Aug 26, 2020

View reviewed changes

pkg/cvo/cvo.go Show resolved Hide resolved

jottofar force-pushed the ota-190-library-go-reuse branch from 491e499 to 34cc37c Compare August 31, 2020 13:46

jottofar force-pushed the ota-190-library-go-reuse branch from 34cc37c to f23ecf6 Compare October 6, 2020 13:30

jottofar force-pushed the ota-190-library-go-reuse branch 3 times, most recently from 415528b to a2ae4fe Compare October 19, 2020 16:09

jottofar force-pushed the ota-190-library-go-reuse branch from a2ae4fe to b3c36da Compare October 27, 2020 14:11

wking reviewed Nov 16, 2020

View reviewed changes

pkg/cvo/cvo_test.go Outdated Show resolved Hide resolved

jottofar added 2 commits November 18, 2020 09:08

Bump library-go to pick up packages manifest and verify

c2cfefb

Steps: $ go get github.com/openshift/library-go $ go mod tidy $ go mod vendor using: $ go version go version go1.15.3 linux/amd64

Modify to use library-go manifest and verify packages

ce2874f

library-go manifest and verify packages were created since both CVO and the oc client use them.

jottofar force-pushed the ota-190-library-go-reuse branch from b3c36da to ce2874f Compare November 18, 2020 14:11

openshift-ci-robot assigned wking Dec 6, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2020

openshift-merge-robot merged commit 84b3884 into openshift:master Dec 6, 2020

wking added a commit to wking/cluster-version-operator that referenced this pull request May 4, 2021

hack/generate-lib-resources: Use library-go manifests

93b1cc9

Catching the generator up with ce2874f (Modify to use library-go manifest and verify packages, 2020-08-25, openshift#443).

wking mentioned this pull request May 4, 2021

hack/generate-lib-resources: Use library-go manifests #552

Merged

Modify to use library-go manifest and verify packages #443

Modify to use library-go manifest and verify packages #443

Uh oh!

Conversation

jottofar commented Aug 25, 2020

Uh oh!

jottofar commented Aug 25, 2020

Uh oh!

jottofar commented Aug 25, 2020

Uh oh!

Uh oh!

jottofar commented Aug 31, 2020

Uh oh!

jottofar commented Sep 7, 2020

Uh oh!

jottofar commented Sep 7, 2020

Uh oh!

openshift-ci-robot commented Sep 7, 2020

Uh oh!

jottofar commented Sep 16, 2020

Uh oh!

openshift-ci-robot commented Sep 16, 2020

Uh oh!

jottofar commented Sep 16, 2020

Uh oh!

openshift-ci-robot commented Sep 16, 2020

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

jottofar commented Oct 23, 2020

Uh oh!

jottofar commented Oct 27, 2020

Uh oh!

Uh oh!

jottofar commented Nov 18, 2020

Uh oh!

jottofar commented Nov 18, 2020

Uh oh!

jottofar commented Nov 18, 2020

Uh oh!

jottofar commented Nov 18, 2020

Uh oh!

wking commented Dec 5, 2020

Uh oh!

wking commented Dec 6, 2020

Uh oh!

openshift-ci-robot commented Dec 6, 2020

Uh oh!

openshift-ci-robot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-merge-robot commented Dec 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

Reviewers

Assignees

Labels

openshift-merge-robot commented Dec 6, 2020 •

edited

Loading