Skip to content

[release-4.6] Bug 1886947: pkg/cvo/sync_worker: Drop "Manifest: ..." logging #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Oct 10, 2020
Merged

[release-4.6] Bug 1886947: pkg/cvo/sync_worker: Drop "Manifest: ..." logging #471

openshift-merge-robot merged 2 commits into from
Oct 10, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 9, 2020

This is an automated cherry-pick of #469

/assign vrutkovs

@wking
pkg/cvo/sync_worker: Drop "Manifest: ..." logging
b2466ba 
This line is descended from logging we grew way back in 847f71b
(pkg/cvo: update to new updatepayload structure, 2018-09-18, openshift#14).
But we triggered it recently with 88c222c
(install/0000_00_cluster-version-operator_03_deployment: Bump to
--v=5, 2020-08-30, openshift#448).  Drop the line, because it's noisy spew in
the log files, and we can get the manifest content via:

  $ oc adm release extract --to=manifests $PULLSPEC
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020

@openshift-cherrypick-robot: Bugzilla bug 1886900 has been cloned as Bugzilla bug 1886947. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1886947: pkg/cvo/sync_worker: Drop "Manifest: ..." logging

Details

In response to this:

[release-4.6] Bug 1886900: pkg/cvo/sync_worker: Drop "Manifest: ..." logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1886900: pkg/cvo/sync_worker: Drop "Manifest: ..." logging [release-4.6] Bug 1886947: pkg/cvo/sync_worker: Drop "Manifest: ..." logging Oct 9, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1886947, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1886900 is in the state MODIFIED, which is one of the valid states (MODIFIED, VERIFIED)
  • dependent Bugzilla bug 1886900 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

[release-4.6] Bug 1886947: pkg/cvo/sync_worker: Drop "Manifest: ..." logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs
vrutkovs approved these changes Oct 9, 2020
View reviewed changes
Copy link

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2020
@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 9, 2020
@wking
Copy link
Member

wking commented Oct 9, 2020

/hold

Until we confirm the fix in 4.7.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2020
@wking wking mentioned this pull request Oct 9, 2020
Merged
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@sdodson
Copy link
Member

sdodson commented Oct 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@wking
pkg/cvo/sync_worker: Demote "Status change: ..." logging to v6
eda5997 
And also the "Status report channel was full" lines.  These lines are
descended from 961873d (sync: Do config syncing in the background,
2019-01-11, openshift#82).  But we triggered it recently with 88c222c
(install/0000_00_cluster-version-operator_03_deployment: Bump to
--v=5, 2020-08-30, openshift#448).  Drop the line, because it's noisy spew in
the log files, with all of the small "fraction-completed" bumps:

  $ grep -c 'sync_worker.go:.*Status change' namespaces/openshift-cluster-version/pods/cluster-version-operator-*/cluster-version-operator/cluster-version-operator/logs/current.log
  6265
  $ grep -c 'sync_worker.go:.*Status report channel was full' namespaces/openshift-cluster-version/pods/cluster-version-operator-*/cluster-version-operator/cluster-version-operator/logs/current.log
  5586
  $ grep 'sync_worker.go:.*Status change' namespaces/openshift-cluster-version/pods/cluster-version-operator-*/cluster-version-operator/cluster-version-operator/logs/current.log | tail -n4
  2020-10-09T18:21:53.523398340Z I1009 18:21:53.522733       1 sync_worker.go:458] Status change cvo.SyncWorkerStatus{Generation:1, Step:"ApplyResources", Failure:error(nil), Fraction:0.9936, Completed:0, Reconciling:true, Initial:false, VersionHash:"NtNVAdtksjk=", LastProgress:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}, Actual:v1.Release{Version:"4.7.0-0.ci.test-2020-10-09-171926-ci-op-8r50wp9l", Image:"registry.build01.ci.openshift.org/ci-op-8r50wp9l/release@sha256:9c90e64d7ccec7475608daf3e7a21ed749d047a330203734501eb7bc95c65ac8", URL:"", Channels:[]string(nil)}, Verified:false}
  2020-10-09T18:21:53.538399862Z I1009 18:21:53.537709       1 sync_worker.go:458] Status change cvo.SyncWorkerStatus{Generation:1, Step:"ApplyResources", Failure:error(nil), Fraction:0.9952, Completed:0, Reconciling:true, Initial:false, VersionHash:"NtNVAdtksjk=", LastProgress:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}, Actual:v1.Release{Version:"4.7.0-0.ci.test-2020-10-09-171926-ci-op-8r50wp9l", Image:"registry.build01.ci.openshift.org/ci-op-8r50wp9l/release@sha256:9c90e64d7ccec7475608daf3e7a21ed749d047a330203734501eb7bc95c65ac8", URL:"", Channels:[]string(nil)}, Verified:false}
  2020-10-09T18:21:53.570915921Z I1009 18:21:53.570847       1 sync_worker.go:458] Status change cvo.SyncWorkerStatus{Generation:1, Step:"ApplyResources", Failure:error(nil), Fraction:0.9984, Completed:0, Reconciling:true, Initial:false, VersionHash:"NtNVAdtksjk=", LastProgress:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}, Actual:v1.Release{Version:"4.7.0-0.ci.test-2020-10-09-171926-ci-op-8r50wp9l", Image:"registry.build01.ci.openshift.org/ci-op-8r50wp9l/release@sha256:9c90e64d7ccec7475608daf3e7a21ed749d047a330203734501eb7bc95c65ac8", URL:"", Channels:[]string(nil)}, Verified:false}
  2020-10-09T18:21:53.585933980Z I1009 18:21:53.585786       1 sync_worker.go:458] Status change cvo.SyncWorkerStatus{Generation:1, Step:"", Failure:error(nil), Fraction:1, Completed:10, Reconciling:true, Initial:false, VersionHash:"NtNVAdtksjk=", LastProgress:time.Time{wall:0xbfd8487062ea4a14, ext:2681032283239, loc:(*time.Location)(0x26b0400)}, Actual:v1.Release{Version:"4.7.0-0.ci.test-2020-10-09-171926-ci-op-8r50wp9l", Image:"registry.build01.ci.openshift.org/ci-op-8r50wp9l/release@sha256:9c90e64d7ccec7475608daf3e7a21ed749d047a330203734501eb7bc95c65ac8", URL:"", Channels:[]string(nil)}, Verified:false}
@wking wking force-pushed the cherry-pick-469-to-release-4.6 branch from 5b41b74 to eda5997 Compare October 9, 2020 23:38
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@wking
Copy link
Member

wking commented Oct 9, 2020

/lgtm

^ GitHub just noticed me re-injecting the #472 cherry-pick

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sdodson, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [sdodson,vrutkovs,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@wking
Copy link
Member

wking commented Oct 9, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit c35a4e1 into openshift:release-4.6 Oct 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 10, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1886947 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.6] Bug 1886947: pkg/cvo/sync_worker: Drop "Manifest: ..." logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@wking wking Awaiting requested review from wking

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdodson sdodson

@vrutkovs vrutkovs

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @wking @sdodson @vrutkovs @openshift-merge-robot