Update CVO to flat updatepayload structure #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
Contributor
Author
|
/retest |
abhinavdahiya
force-pushed
the
op_rb
branch
from
19b36c1 to
847f71b
Compare
yifan-gu
reviewed
Sep 19, 2018
| type ResourceMapper struct { | ||
| l *sync.Mutex | ||
|
|
||
| gvkToNew map[schema.GroupVersionKind]NewInteraceFunc |
Contributor
Author
There was a problem hiding this comment.
gvk : GroupVersionKind
|
@abhinavdahiya code wise lgtm, but I'm kinda lost at this point on what's going on with the current cvo state... Maybe need another pair of eyes? |
yifan-gu
approved these changes
Sep 20, 2018
yifan-gu
left a comment
yifan-gu
left a comment
There was a problem hiding this comment.
/lgtm
@abhinavdahiya walked me through the changes now I have a better understanding of the purpose of the PR. 👍
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Oct 9, 2020
This line is descended from logging we grew way back in 847f71b (pkg/cvo: update to new updatepayload structure, 2018-09-18, openshift#14). But we triggered it recently with 88c222c (install/0000_00_cluster-version-operator_03_deployment: Bump to --v=5, 2020-08-30, openshift#448). Drop the line, because it's noisy spew in the log files, and we can get the manifest content via: $ oc adm release extract --to=manifests $PULLSPEC
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/cluster-version-operator
that referenced
this pull request
Oct 9, 2020
This line is descended from logging we grew way back in 847f71b (pkg/cvo: update to new updatepayload structure, 2018-09-18, openshift#14). But we triggered it recently with 88c222c (install/0000_00_cluster-version-operator_03_deployment: Bump to --v=5, 2020-08-30, openshift#448). Drop the line, because it's noisy spew in the log files, and we can get the manifest content via: $ oc adm release extract --to=manifests $PULLSPEC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/resourcebuilderto be allow for adding custom resource builders/cc @yifan-gu