-
Notifications
You must be signed in to change notification settings - Fork 213
docs/dev/clusteroperator: Point at the reconciliation docs #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/dev/clusteroperator: Point at the reconciliation docs #274
Conversation
cde8d50 (docs/user/reconciliation: Document release-image application, 2019-06-10, openshift#201) just landed, so drop some of the reconciliation docs from the parallel 105ea1f (document CVO behavior w/ respect to cluster operator conditions, 2019-07-12, openshift#222) and similar in favor of a link to the new reconciliation location. Also move the file-extension note over to the reconciliation side, since it's more generic than ClusterOperator. It's not really user docs either, but that's the most generic location we have at the moment. Also fix a few more Failing->Degraded bits to catch up with fad0688 (pkg/cvo/metrics/go: the cluster operators report Degraded and not Failing, 2019-08-07, openshift#232) and similar.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| #### Conditions and Install/Upgrade | ||
|
|
||
| Conditions determine when the CVO considers certain actions complete, the following table summarizes what it looks at and when. | ||
|
|
||
|
|
||
| | operation | version | available | degraded | progressing | | ||
| |-----------|---------|-----------|----------|-------------| | ||
| | Install completion[1] | current(whatever was being installed) | true | any | any | ||
| | Begin upgrade | any | any | any | any | ||
| | Begin upgrade (w/ force) | any | any | any | any | ||
| | Upgrade completion[2]| newVersion(target version for the upgrade) | true | false | false | ||
|
|
||
| [1] Install works on all components in parallel, it does not wait for any component to complete before starting another one. | ||
|
|
||
| [2] Upgrade will not proceed with upgrading components in the next runlevel until the previous runlevel completes. | ||
|
|
||
| See also: https://github.com/openshift/cluster-version-operator/blob/a5f5007c17cc14281c558ea363518dcc5b6675c7/pkg/cvo/internal/operatorstatus.go#L176-L189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we remove this section ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's covered in the reconciliation doc. Was there anything here you think is not reflected there?
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@wking: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cde8d50 (#201) just landed, so drop some of the reconciliation docs from the parallel 105ea1f (#222) and similar in favor of a link to the new reconciliation location.
Also move the file-extension note over to the reconciliation side, since it's more generic than ClusterOperator. It's not really user docs either, but that's the most generic location we have at the moment.
Also fix a few more
Failing->Degradedbits to catch up with fad0688 (#232) and similar.