-
Notifications
You must be signed in to change notification settings - Fork 213
document CVO behavior w/ respect to cluster operator conditions #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a5fc479 to
8246076
Compare
|
/assign @abhinavdahiya (should update this w/ the upgradeable condition when that is a thing) |
docs/dev/clusteroperator.md
Outdated
| | Begin upgrade (w/ force) | any | any | any | any | ||
| | Upgrade completion[2]| newVersion(target version for the upgrade) | true | false | false | ||
|
|
||
| [1] Install cannot proceed to the next cluster operator until the previous cluster operator achieves these conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
during install we allow all operators to be created at once _ same level_
cc @smarterclayton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, i'll clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhinavdahiya fyi when I talked to @smarterclayton he said we created all operators at once, period (regardless of runlevel), so i updated the doc to reflect that.
docs/dev/clusteroperator.md
Outdated
| | Begin upgrade (w/ force) | any | any | any | any | ||
| | Upgrade completion[2]| newVersion(target version for the upgrade) | true | false | false | ||
|
|
||
| [1] Install cannot proceed to cluster operators in the next runlevel until all cluster operators in the current runlevel achieve these conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhinavdahiya updated ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused what you mean here - ordering only matters during upgrade, it's ignored on install and sync? Maybe I'm misinterpreting what you mean by run level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ordering only matters during upgrade, it's ignored on install and sync
that's what i was trying to say, yes. By runlevel i meant like "70_blah". My understanding was everything at run level 70 runs in parallel during install. then everything at runlevel 71. etc.
and then during upgrade I was trying to say it's fully ordered, no parallelization.
I wasn't trying to say anything about sync.
|
@abhinavdahiya i think this is ready to go? |
|
|
||
| [1] Install works on all components in parallel, it does not wait for any component to complete before starting another one. | ||
|
|
||
| [2] Upgrade will not proceed with upgrading components in the next runlevel until the previous runlevel completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smarterclayton @abhinavdahiya updated these descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine with me
|
/approve will let @smarterclayton lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, bparees The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
cde8d50 (docs/user/reconciliation: Document release-image application, 2019-06-10, openshift#201) just landed, so drop some of the reconciliation docs from the parallel 105ea1f (document CVO behavior w/ respect to cluster operator conditions, 2019-07-12, openshift#222) and similar in favor of a link to the new reconciliation location. Also move the file-extension note over to the reconciliation side, since it's more generic than ClusterOperator. It's not really user docs either, but that's the most generic location we have at the moment. Also fix a few more Failing->Degraded bits to catch up with fad0688 (pkg/cvo/metrics/go: the cluster operators report Degraded and not Failing, 2019-08-07, openshift#232) and similar.
No description provided.