Skip to content

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Jul 12, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 12, 2019
@bparees bparees force-pushed the conditions branch 2 times, most recently from a5fc479 to 8246076 Compare July 12, 2019 22:35
@bparees
Copy link
Contributor Author

bparees commented Jul 12, 2019

/assign @abhinavdahiya

(should update this w/ the upgradeable condition when that is a thing)

| Begin upgrade (w/ force) | any | any | any | any
| Upgrade completion[2]| newVersion(target version for the upgrade) | true | false | false

[1] Install cannot proceed to the next cluster operator until the previous cluster operator achieves these conditions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during install we allow all operators to be created at once _ same level_
cc @smarterclayton

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, i'll clarify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdahiya fyi when I talked to @smarterclayton he said we created all operators at once, period (regardless of runlevel), so i updated the doc to reflect that.

| Begin upgrade (w/ force) | any | any | any | any
| Upgrade completion[2]| newVersion(target version for the upgrade) | true | false | false

[1] Install cannot proceed to cluster operators in the next runlevel until all cluster operators in the current runlevel achieve these conditions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdahiya updated ^^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused what you mean here - ordering only matters during upgrade, it's ignored on install and sync? Maybe I'm misinterpreting what you mean by run level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ordering only matters during upgrade, it's ignored on install and sync

that's what i was trying to say, yes. By runlevel i meant like "70_blah". My understanding was everything at run level 70 runs in parallel during install. then everything at runlevel 71. etc.

and then during upgrade I was trying to say it's fully ordered, no parallelization.

I wasn't trying to say anything about sync.

@bparees
Copy link
Contributor Author

bparees commented Jul 15, 2019

@abhinavdahiya i think this is ready to go?


[1] Install works on all components in parallel, it does not wait for any component to complete before starting another one.

[2] Upgrade will not proceed with upgrading components in the next runlevel until the previous runlevel completes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarterclayton @abhinavdahiya updated these descriptions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me

@abhinavdahiya
Copy link
Contributor

/approve

will let @smarterclayton lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 647bce3 into openshift:master Jul 25, 2019
wking added a commit to wking/cluster-version-operator that referenced this pull request Nov 27, 2019
cde8d50 (docs/user/reconciliation: Document release-image
application, 2019-06-10, openshift#201) just landed, so drop some of the
reconciliation docs from the parallel 105ea1f (document CVO
behavior w/ respect to cluster operator conditions, 2019-07-12, openshift#222)
and similar in favor of a link to the new reconciliation location.

Also move the file-extension note over to the reconciliation side,
since it's more generic than ClusterOperator.  It's not really user
docs either, but that's the most generic location we have at the
moment.

Also fix a few more Failing->Degraded bits to catch up with fad0688
(pkg/cvo/metrics/go: the cluster operators report Degraded and not
Failing, 2019-08-07, openshift#232) and similar.
@bparees bparees deleted the conditions branch March 26, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants