Add render subcommand for CVO #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
abhinavdahiya
force-pushed
the
cvo_render
branch
3 times, most recently
from
6bec601 to
1066bb3
Compare
openshift-ci-robot
added
size/M
abhinavdahiya
force-pushed
the
cvo_render
branch
from
1066bb3 to
f75e390
Compare
openshift-ci-robot
added
size/L
abhinavdahiya
force-pushed
the
cvo_render
branch
from
f75e390 to
d7a06ba
Compare
CVO uses the value --release-image for templating in default case But when desiredupdate payload is set, it uses that image as release image for templating.
Render renderes all the manifests from UpdatePayload It skips certian specific Kinds that have might not be useful It also errors if a manifest exists in UpdatePayload that it cannot manage when reconciling.
abhinavdahiya
force-pushed
the
cvo_render
branch
from
d7a06ba to
2223542
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #15
/cc @yifan-gu