Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Sep 19, 2018

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 19, 2018
@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2018
@openshift-merge-robot openshift-merge-robot merged commit 0be66ae into openshift:master Sep 20, 2018
Use: "image",
Short: "Returns image for requested short-name from UpdatePayload",
Long: "",
Example: "%[1] image <short-name>",
Copy link

@yifan-gu yifan-gu Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the %[1] print the parent command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the %[1] print the parent command?

No, will fix that in follow up PR.

@abhinavdahiya abhinavdahiya deleted the image_refs branch September 20, 2018 15:48
@wking
Copy link
Member

wking commented Jun 10, 2020

Copying the motivation from the private tracker out into this public space:

CVO needs to be able to output container image references on the bootstrap node. This is needed so that we can run KCO and MCO in bootstrap mode. CVO needs an interface similar to:

$ cvo --image-reference kube-core-operator
quay.io/openshift/kube-core-operator

The bootstrap machine has a copy of oc (e.g. see here), but using oc adm release info --image-for=... ... would bypass the local image cache. Using podman to call the same CVO/release image repeatedly is cheaper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants