Bug 1986215: Bump library-go to get leader election fixes#196
Conversation
This bump is intended to address the issue that SNO cluster cannot handle 60s of API server communication disruptions. The fix was added in openshift/library-go#1104.
It does not seem necessary anymore. In addition to that, the build is failing because of it.
Remove k8s.io/code-generator and go-bindata. These are no longer required as we have migrated to the embeded built-in package and we no do not use local APIs anymore.
openshift-ci
bot
added
bugzilla/severity-high
|
@bertinatto: This pull request references Bugzilla bug 1986215, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@bertinatto: All pull requests linked via external trackers have merged: Bugzilla bug 1986215 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Leader election fix introduced in openshift/library-go#1104.
Basically it allows CSO to handle 60s of communication disruption with the API server. This is relevant for single-node clusters.
CC @openshift/storage