Bug 1986215: Bump library-go#98
Conversation
For leader-election fixes to allow longer API server disruptions for single node clusters.
Add context to places where it's required.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@jsafrane: This pull request references Bugzilla bug 1986215, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jsafrane: All pull requests linked via external trackers have merged: Bugzilla bug 1986215 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For leader-election fixes to allow longer API server disruptions for single node clusters.
I need to add
contextto some calls, usingcontext.TODO(). In the future it would be better to rework the controller to havesync()call with context, as usual library-go controllers do.