Bug 1818476: copy install pull secret when boostrapped as removed#256
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@gabemontero: This pull request references Bugzilla bug 1818476, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabemontero: This pull request references Bugzilla bug 1818476, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
| return err | ||
| } | ||
| } | ||
| if removedState { |
There was a problem hiding this comment.
for cross reference, this path should never have been entered, per https://github.com/openshift/cluster-samples-operator/blob/master/pkg/stub/handler.go#L561-L562
|
/retest |
|
I should also note, I tested this manually by temporarily marking x86 as bootstrapped as removed in my local cluster. Repro'ed the bug, then verified the fix @adambkaplan |
|
/retest |
|
all green tests @adambkaplan and of course let me know if you'd prefer someone else from @openshift/openshift-team-developer-experience looking at this one |
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
@gabemontero please add an e2e check that verifies the pull secret remains after we mark the samples operator removed.
gabemontero
force-pushed
the
test-boot-rm-secret
branch
from
d67d9f5 to
3b88fde
Compare
|
secret still present verification added @adambkaplan - thanks |
|
|
|
/retest |
|
all tests still green after updating e2e |
|
|
||
| verifyImageStreamsGone(t) | ||
| verifyTemplatesGone(t) | ||
| verifySecretPresent(t) |
There was a problem hiding this comment.
the update per @adambkaplan 's ask in #256 (review)
|
/assign @dmage |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gabemontero: All pull requests linked via external trackers have merged: openshift/cluster-samples-operator#256. Bugzilla bug 1818476 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabemontero: All pull requests linked via external trackers have merged: openshift/cluster-samples-operator#256. Bugzilla bug 1818476 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.4 |
|
@gabemontero: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cluster-samples-operator\n ! [remote rejected] cherry-pick-256-to-release-4.4 -> cherry-pick-256-to-release-4.4 (cannot lock ref 'refs/heads/cherry-pick-256-to-release-4.4': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cluster-samples-operator'\n", error: exit status 1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabemontero: new pull request created: #266 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.3 |
|
@gabemontero: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cluster-samples-operator\n ! [remote rejected] cherry-pick-256-to-release-4.3 -> cherry-pick-256-to-release-4.3 (cannot lock ref 'refs/heads/cherry-pick-256-to-release-4.3': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cluster-samples-operator'\n", error: exit status 1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabemontero: new pull request created: #267 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
/assign @adambkaplan