Skip to content

takes encryption controllers from apiservercontrollerset#346

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
p0lyn0mial:encryption-controllers-from-api-server-cs
Mar 30, 2020
Merged

takes encryption controllers from apiservercontrollerset#346
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
p0lyn0mial:encryption-controllers-from-api-server-cs

Conversation

@p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Mar 26, 2020

No description provided.

@p0lyn0mial p0lyn0mial mentioned this pull request Mar 27, 2020
Merged
@p0lyn0mial p0lyn0mial force-pushed the encryption-controllers-from-api-server-cs branch from 2726acd to 975de78 Compare March 27, 2020 13:32
@p0lyn0mial p0lyn0mial changed the title wip takes encryption controllers from apiservercontrollerset Mar 27, 2020
@p0lyn0mial p0lyn0mial mentioned this pull request Mar 27, 2020
Closed
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Mar 30, 2020

/retest

sttts
sttts reviewed Mar 30, 2020
View reviewed changes
pkg/operator/starter.go
}

migrationClient := kubemigratorclient.NewForConfigOrDie(controllerConfig.KubeConfig)
migrationInformer := migrationv1alpha1informer.NewSharedInformerFactory(migrationClient, time.Minute*30)
Copy link
Contributor

@sttts sttts Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this started?

Copy link
Contributor Author

@p0lyn0mial p0lyn0mial Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not ! fixing, thx!

@p0lyn0mial p0lyn0mial force-pushed the encryption-controllers-from-api-server-cs branch from 975de78 to 4d71039 Compare March 30, 2020 07:59
@sttts
Copy link
Contributor

sttts commented Mar 30, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d16e120 into openshift:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh Awaiting requested review from soltysh

1 more reviewer

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@p0lyn0mial @sttts @openshift-ci-robot @openshift-bot @openshift-merge-robot