Skip to content

Add encryption controllers to apiservercontrollerset#299

Closed
stlaz wants to merge 2 commits intoopenshift:masterfrom
stlaz:encryption_controllers
Closed

Add encryption controllers to apiservercontrollerset#299
stlaz wants to merge 2 commits intoopenshift:masterfrom
stlaz:encryption_controllers

Conversation

@stlaz
Copy link
Contributor

@stlaz stlaz commented Jan 16, 2020

This uses an unmerged version of the apiserver controller sets from library-go (openshift/library-go#667), adds encryption controllers on top

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stlaz
To complete the pull request process, please assign mfojtik
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stlaz stlaz force-pushed the encryption_controllers branch from 7abcd83 to e5f68e7 Compare January 21, 2020 09:36
@stlaz
Copy link
Contributor Author

stlaz commented Jan 21, 2020

/retest

1 similar comment
@stlaz
Copy link
Contributor Author

stlaz commented Jan 21, 2020

/retest

@openshift-ci-robot
Copy link

@stlaz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade e5f68e7 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2020
@openshift-ci-robot
Copy link

@stlaz: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor

/close

deprecated by #346

@openshift-ci-robot
Copy link

@p0lyn0mial: Closed this PR.

Details

In response to this:

/close

deprecated by #346

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants