-
Notifications
You must be signed in to change notification settings - Fork 33
OCPBUGS-62173: Add TLSSecurityProfile controller #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
Adds a TLSSecurityProfile controller and informer to update the operator-controller and catalogd deployments when apiservers.config.openshift.io changes. Signed-off-by: Todd Short <[email protected]>
|
/retest-required |
|
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I tested this PR, looks like it still uses the hardcoded TLS. Or am I missing something? Thanks! launch 4.21,openshift/cluster-olm-operator#143 aws
jiazha-mac:~ jiazha$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.21.0-0-2025-10-16-031605-test-ci-ln-xzn3wgt-latest True False 41m Cluster version is 4.21.0-0-2025-10-16-031605-test-ci-ln-xzn3wgt-latest
jiazha-mac:~ jiazha$ oc get deploy catalogd-controller-manager -o yaml |grep tls -A2
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --v=4
- --global-pull-secret=openshift-config/pull-secret
--
- key: tls.crt
path: tls.crt
- key: tls.key
path: tls.key
optional: false
secretName: catalogserver-cert
|
|
Closing this PR in favor of another method |
|
@tmshort: This pull request references Jira Issue OCPBUGS-62173. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Adds a TLSSecurityProfile controller and informer to update the operator-controller and catalogd deployments when
apiservers.config.openshift.io changes.
/hold
This uses my own version of library-go to make sure things build and test.