OCPBUGS-62173: Add TLS config observer to update opcon/catd

[tmshort]

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

• --tls-custom-ciphers=X,Y,Z
• --tls-custom-version=N
• --tls-profile=custom

In addition:

• Update library-go to include the TLS config observer
• Move the deployment update hooks (proxy, TLS) into their own files
• Add unit tests
• Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short [email protected]
Co-Authored-By: Claude [email protected]

[openshift-ci-robot]

@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add an apiserver TLS config observer. This examines TLS config and copies the values into the .spec.observedConfig field of the olms.operator.openshift.io/cluster resource. This is then used to apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

• --tls-custom-ciphers=X,Y,Z
• --tls-custom-version=N
• --tls-profile=custom

In addition:

• Update library-go to include the TLS config observer
• Move the deployment update hooks (proxy, TLS) into their own files
• Add unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

• --tls-custom-ciphers=X,Y,Z
• --tls-custom-version=N
• --tls-profile=custom

In addition:

• Update library-go to include the TLS config observer
• Move the deployment update hooks (proxy, TLS) into their own files
• Add unit tests
• Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short [email protected]
Co-Authored-By: Claude [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tmshort]

/test openshift-e2e-aws
/test openshift-e2e-aws-techpreview

[camilamacedo86]

/retest-required

[tmshort]

openshift-e2e-aws-devpreview is failing with this:

: [sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should be able to connect to a service that is idled because a GET on the route will unidle it [Suite:openshift/conformance/parallel/minimal] 

Which seems unrelated. After approvals, I will re-run it, but I may override it.

[tmshort]

/test openshift-e2e-aws-devpreview

[openshift-ci]

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	de8017a	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jianzhangbjz]

I guess it supersedes #143

[jianzhangbjz]

Test passed. Details: https://issues.redhat.com/browse/OCPBUGS-62173
/verified by @jianzhangbjz
/lgtm

[openshift-ci-robot]

@jianzhangbjz: This PR has been marked as verified by @jianzhangbjz.

In response to this:

Test passed. Details: https://issues.redhat.com/browse/OCPBUGS-62173
/verified by @jianzhangbjz
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tmshort: Jira Issue Verification Checks: Jira Issue OCPBUGS-62173
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62173 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

• --tls-custom-ciphers=X,Y,Z
• --tls-custom-version=N
• --tls-profile=custom

In addition:

• Update library-go to include the TLS config observer
• Move the deployment update hooks (proxy, TLS) into their own files
• Add unit tests
• Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short [email protected]
Co-Authored-By: Claude [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.21.0-0.nightly-2025-10-30-060549