Skip to content

Adds .svc and .cluster.local to default noProxy #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 21, 2019
Merged

Adds .svc and .cluster.local to default noProxy #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/util/proxyconfig/merge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ func MergeUserSystemNoProxy(proxy *configv1.Proxy, infra *configv1.Infrastructur
set := sets.NewString(
"127.0.0.1",
"localhost",
".svc",
".cluster.local",
Copy link
Member

@runcom runcom Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be done in the installer as well

Copy link
Member

@runcom runcom Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @abhinavdahiya related to https://bugzilla.redhat.com/show_bug.cgi?id=1744532#c13

Copy link
Member

@runcom runcom Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempted to fix this here openshift/installer#2257

)

if len(infra.Status.APIServerURL) > 0 {
Expand Down