Bug 1744532: proxy: add .svc and .cluster.local to default noProxy

[runcom]

Proxy controller (I think) changed this openshift/cluster-network-operator#295 but the installer isn't doing the same. This is causing a different proxy config being generated between bootstrap and in-cluster which in turn causes the MCO to generates different machineconfigs and resulting in https://bugzilla.redhat.com/show_bug.cgi?id=1744532#c13

Signed-off-by: Antonio Murdaca runcom@linux.com

[runcom]

/retest

[sdodson]

This list still differs from the list in cluster-network-operator, do they need to be exactly the same?

[runcom]

So from investigating that bug linked I noticed that those two were the hostnames missing, can't speak for the other differences between the lists but if they differs between bootstrap and in-cluster the MCO cannot proceed.

[runcom]

Another question would be why this is only noticed on vsphere upi and not on aws ipi - not knowledgeable enough for that

[sdodson]

Ok, I agree those should be added here. Just seemed like you were suggesting the lists needed to be identical to avoid problems.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

Ok, I agree those should be added here. Just seemed like you were suggesting the lists needed to be identical to avoid problems.

so I'm not entirely sure about the list being identical :) just from debugging, .svc and .cluster.local are indeed missing from the noProxy list that the installer generates at bootstrap. Then, when the bootstrap is over, the MCO gets a proxy object that does have those 2 additional hostnames causing a skew and the subsequent MCO wedge.
Thanks!

[openshift-ci-robot]

@runcom: This pull request references Bugzilla bug 1744532, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1744532: proxy: add .svc and .cluster.local to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[runcom]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

... but if they differs between bootstrap and in-cluster the MCO cannot proceed.

So how do we ratchet future adjustments in without breaking anything? Ideally the installer-generated defaults would just be enough for the installer to be able to reach the registry to pull the release image and dependencies. Then we'd run the networking operator to (re-)render the manifest before pushing into the cluster to stay in sync?

[runcom]

So how do we ratchet future adjustments in without breaking anything?

so, one of the mystery here is that, apparently, this only happened on vsphere and hasn't happened on aws api so I think our current CI should have caught this just fine.

Ideally the installer-generated defaults would just be enough for the installer to be able to reach the registry to pull the release image and dependencies. Then we'd run the networking operator to (re-)render the manifest before pushing into the cluster to stay in sync?

we could do this yeah, right now, the installer has to keep up with networking operator changes as we've spotted here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@runcom: All pull requests linked via external trackers have merged. Bugzilla bug 1744532 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1744532: proxy: add .svc and .cluster.local to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.