Adds cvo opt-in annotation for proxy

[danehans]

Required by #277

Adds cvo proxy opt-in annotation to inject proxy env var's from openshift/cluster-version-operator#224.

/assign @squeed @bparees

[danehans]

@squeed I can use some guidance on how this should be tested. I was thinking an e2e, but I don't see any exist e2e for CNO.

[squeed]

@danehans yeah, we don't have plans for this kind of e2e (though we have designs for other e2e bits..). Honestly the best way to test this, if you're not sure that it does what it should, is to jump on the CI cluster and check everything out.

[squeed]

Hmm - if we're the ones generating this, can we just update our own env ;-) ?

[bparees]

Hmm - if we're the ones generating this, can we just update our own env ;-) ?

?

the operator deployment is managed by the CVO. So you need this annotation so the CVO will add the proxy env vars to your deployment. If you tried to add them yourself, the CVO would stomp your deployment back to what it thinks it is supposed to look like (no env vars)

[squeed]

the operator deployment is managed by the CVO. So you need this annotation so the CVO will add the proxy env vars to your deployment. If you tried to add them yourself, the CVO would stomp your deployment back to what it thinks it is supposed to look like (no env vars)

I just meant with os.Setenv(). But perhaps that's racy.

[bparees]

I just meant with os.Setenv(). But perhaps that's racy.

we were told that golang's transport libs initilize on load, so setting the env var after is not going to have a useful effect.

and @danehans that is something to consider when you are doing your readiness endpoint checking as well... ensuring that the transport connection you are opening is actually going through the proxy (in addition to using the generated CA bundle)

[bparees]

/lgtm
(I don't have approver on this repo)

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees, danehans
To complete the pull request process, please assign squeed
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[danehans]

@bparees @squat lgtm was removed since I pushed a new commit to fix the annotation value.

[squat]

cc the othe squ.*: @squeed

[danehans]

This PR may not be needed since #277 will use static proxy settings instead of from env vars.

/hold

[bparees]

This PR may not be needed since #277 will use static proxy settings instead of from env vars.

it's needed if and only if the network operator itself (not its operands) needs to make off-cluster requests. (not including the off-cluster requests that will be made to the proxy readiness endpoint)

[danehans]

Closing b/c we don't believe CNO needs to consume proxy.