Adds readinessEndpoint validation for Proxy API type. #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Contributor
Author
|
/hold until #245 merges. |
Contributor
Author
bparees
reviewed
Aug 7, 2019
danehans
force-pushed
the
proxy_reconciler_readiness
branch
from
fa5cdf7 to
065bdea
Compare
openshift-ci-robot
added
size/XL
danehans
force-pushed
the
proxy_reconciler_readiness
branch
from
065bdea to
2133230
Compare
openshift-ci-robot
added
size/M
danehans
force-pushed
the
proxy_reconciler_readiness
branch
from
736afb6 to
9867c9e
Compare
bparees
reviewed
Aug 8, 2019
danehans
force-pushed
the
proxy_reconciler_readiness
branch
from
9867c9e to
0e017e3
Compare
danehans
force-pushed
the
proxy_reconciler_readiness
branch
2 times, most recently
from
5956b54 to
6d0d3e4
Compare
bparees
reviewed
Aug 13, 2019
bparees
reviewed
Aug 13, 2019
danehans
force-pushed
the
proxy_reconciler_readiness
branch
from
6d0d3e4 to
8690692
Compare
danehans
force-pushed
the
proxy_reconciler_readiness
branch
from
8690692 to
d03bf96
Compare
|
/lgtm |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, danehans, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #245.
Proxyvalidation to supportreadinessCheck(when present).http|https|no Proxyspec to status upon successful validation and a successful connection toreadinessEndpoints.Note:
readinessEndpointswith a https URI scheme requires #271.Jira: SDN-492
PTAL @squeed @bparees @JacobTanenbaum