Skip to content

Conversation

@s1061123
Copy link
Contributor

Also changes "operv1.ProxyArgumentList" to fix build error

Also changes "operv1.ProxyArgumentList" to fix build error
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 17, 2019
@s1061123
Copy link
Contributor Author

/assign @danwinship

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2019
@s1061123
Copy link
Contributor Author

thank you for the review, @danwinship!

@squeed
Copy link
Contributor

squeed commented Jul 18, 2019

Hmm, not sure what's up with CI.
/refresh

@s1061123
Copy link
Contributor Author

We get the result for e2e-aws and upgrade may take 2h to complete (from my last result).
Let's see the result...

@openshift-merge-robot openshift-merge-robot merged commit e2285aa into openshift:master Jul 18, 2019
@s1061123 s1061123 deleted the dev/update-dep branch July 18, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants