Skip to content

Conversation

@danehans
Copy link
Contributor

Dep bump needed to consume ReadinessEndpoints from Proxy type for future proxy reconciliation. Required by #245

@squeed @openshift/networking PTAL

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 16, 2019
@danehans danehans mentioned this pull request Jul 16, 2019
3 tasks
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danehans
To complete the pull request process, please assign danwinship
You can assign the PR to them by writing /assign @danwinship in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@squeed
Copy link
Contributor

squeed commented Jul 17, 2019

Looks like that API bump needs a bit of type renaming in the operator code.

@danehans
Copy link
Contributor Author

@squeed I pushed a new commit this morning to handle the renaming.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2019

@danehans: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify aba1df2 link /test verify
ci/prow/unit aba1df2 link /test unit
ci/prow/e2e-aws aba1df2 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@squeed
Copy link
Contributor

squeed commented Jul 18, 2019

Looks like this is also covered in #250

@danwinship
Copy link
Contributor

yeah, #250 did this and is now merged

@danwinship danwinship closed this Jul 18, 2019
@danehans
Copy link
Contributor Author

danehans commented Jul 18, 2019

PR ships in the night ;-)

@danehans danehans deleted the proxy_dep_bump branch July 18, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants