NP-615: Bump github.com/openshift/api by kyrtapz · Pull Request #2138 · openshift/cluster-network-operator

kyrtapz · 2023-11-30T09:26:45Z

This PR bumps Bump github.com/openshift/api.

kyrtapz · 2023-11-30T13:16:24Z

/retest

kyrtapz · 2023-12-01T08:30:30Z

/retest

kyrtapz · 2023-12-01T12:03:26Z

/retest

jcaamano · 2023-12-01T15:16:20Z

/test e2e-network-mtu-migration-ovn-ipv6

jcaamano · 2023-12-01T15:17:28Z

@patryk looks like we have a pretty consistent problem with e2e-aws-ovn-serial. Not an issue introduced with this PR but we are pretty blind there

kyrtapz · 2023-12-01T15:19:38Z

@patryk looks like we have a pretty consistent problem with e2e-aws-ovn-serial. Not an issue introduced with this PR but we are pretty blind there

Yes, the issue is not related to this PR:
https://redhat-internal.slack.com/archives/CDCP2LA9L/p1701424483384129

Edit: it passes now

openshift-ci-robot · 2023-12-01T15:23:05Z

@kyrtapz: This pull request references NP-615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

This PR bumps Bump github.com/openshift/api.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcaamano · 2023-12-01T19:52:31Z

@kyrtapz for the IPv6 MTU migration there is also something fishy with the ns/openshift-cloud-controller-manager-operator that also does not look related to this change.

kyrtapz · 2023-12-04T08:57:34Z

/retest

kyrtapz · 2023-12-04T11:42:13Z

@kyrtapz for the IPv6 MTU migration there is also something fishy with the ns/openshift-cloud-controller-manager-operator that also does not look related to this change.

This job is really flaky in general, I agree that the failures do not look related to the introduced changes (my changes are not ipv6 specific)

jcaamano · 2023-12-04T11:50:39Z

@kyrtapz for the IPv6 MTU migration there is also something fishy with the ns/openshift-cloud-controller-manager-operator that also does not look related to this change.

This job is really flaky in general, I agree that the failures do not look related to the introduced changes (my changes are not ipv6 specific)

Have you seen this now?

 [sig-arch] Managed cluster should only include cluster daemonsets that have maxUnavailable or maxSurge update of 10 percent or maxUnavailable of 33 percent [Suite:openshift/conformance/parallel] expand_less
Run #0: Failed expand_less	4s
{  fail [github.com/openshift/origin/test/extended/operators/daemon_set.go:105]: Daemonsets found that do not meet platform requirements for update strategy:
  expected daemonset openshift-network-node-identity/network-node-identity to have maxUnavailable 10% or 33% (see comment) instead of 0, or maxSurge 10% instead of 100%
Ginkgo exit error 1: exit with code 1}

kyrtapz · 2023-12-04T12:07:06Z

/test e2e-network-mtu-migration-ovn-ipv6

kyrtapz · 2023-12-04T12:10:33Z

@kyrtapz for the IPv6 MTU migration there is also something fishy with the ns/openshift-cloud-controller-manager-operator that also does not look related to this change.

This job is really flaky in general, I agree that the failures do not look related to the introduced changes (my changes are not ipv6 specific)

Have you seen this now?
 [sig-arch] Managed cluster should only include cluster daemonsets that have maxUnavailable or maxSurge update of 10 percent or maxUnavailable of 33 percent [Suite:openshift/conformance/parallel] expand_less
Run #0: Failed expand_less	4s
{  fail [github.com/openshift/origin/test/extended/operators/daemon_set.go:105]: Daemonsets found that do not meet platform requirements for update strategy:
  expected daemonset openshift-network-node-identity/network-node-identity to have maxUnavailable 10% or 33% (see comment) instead of 0, or maxSurge 10% instead of 100%
Ginkgo exit error 1: exit with code 1}

Talked offline, the mentioned failure is not from this PR

mkowalski · 2023-12-04T13:08:20Z

/lgtm

We need this. If this doesn't make it soon, the whole onprem's team work for this cycle will be reverted (because we cannot ship a change without a backing implementation, and the only missing bit is blocked by this here, cc @davegord)

mkowalski · 2023-12-04T15:04:18Z

You folks wait with this, we are reverting on-prem's stuff from openshift/api right now and you will need to revendor anyway

(openshift/api#1694)

kyrtapz · 2023-12-04T16:46:25Z

e2e-network-mtu-migration-ovn-ipv6 passed 🎉

You folks wait with this, we are reverting on-prem's stuff from openshift/api right now and you will need to revendor anyway

(openshift/api#1694)

@jcaamano not sure what we do here. Is it: wait for the revert to get in, revendor and fight CI?

jcaamano · 2023-12-04T17:52:00Z

e2e-network-mtu-migration-ovn-ipv6 passed 🎉

You folks wait with this, we are reverting on-prem's stuff from openshift/api right now and you will need to revendor anyway
(openshift/api#1694)

@jcaamano not sure what we do here. Is it: wait for the revert to get in, revendor and fight CI?

I guess. But should be easier because the next around we will go with just required jobs. Let me know if you would like to do something else, specially if this is blocking you critically.

go get github.com/openshift/api@master go mod tidy && go mod vendor Signed-off-by: Patryk Diak <pdiak@redhat.com>

Operconfig shouldn't own .Spec.Migration as it is not modifying it anywhere. Setting the value to nil will ensure that the value of that field will stay unchanged (including the fieldManager). Co-authored-by: Peng Liu <pliu@redhat.com> Signed-off-by: Patryk Diak <pdiak@redhat.com>

jcaamano · 2023-12-05T12:38:36Z

/lgtm
/approve
/hold

Holding until @kyrtapz is satisfied with CI results. I am ok with Required passing since we already had plenty of greens with the previous API bump. Perhaps also upgrade jobs should pass.

openshift-ci · 2023-12-05T12:39:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kyrtapz · 2023-12-05T13:00:11Z

/test images

kyrtapz · 2023-12-05T15:54:39Z

/retest-required

kyrtapz · 2023-12-05T16:31:33Z

/test 4.15-upgrade-from-stable-4.14-e2e-azure-ovn-upgrade

kyrtapz · 2023-12-05T20:34:33Z

/retest

kyrtapz · 2023-12-06T07:25:39Z

/retest-required

kyrtapz · 2023-12-06T10:43:42Z

/test e2e-hypershift-ovn

openshift-ci · 2023-12-06T12:14:27Z

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-dualstack	`6045ca4`	link	false	`/test e2e-azure-ovn-dualstack`
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	`6045ca4`	link	false	`/test e2e-vsphere-ovn-dualstack-primaryv6`
ci/prow/e2e-network-mtu-migration-ovn-ipv6	`6045ca4`	link	false	`/test e2e-network-mtu-migration-ovn-ipv6`
ci/prow/e2e-azure-ovn	`6045ca4`	link	false	`/test e2e-azure-ovn`
ci/prow/e2e-aws-hypershift-ovn-kubevirt	`6045ca4`	link	false	`/test e2e-aws-hypershift-ovn-kubevirt`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kyrtapz · 2023-12-06T12:29:53Z

/hold cancel

openshift-bot · 2023-12-06T15:03:55Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.16.0-202312061430.p0.g08960c0.assembly.stream for distgit cluster-network-operator.
All builds following this will include this PR.

openshift-ci bot requested review from danwinship and dcbw November 30, 2023 09:28

kyrtapz force-pushed the bump_api branch from 1d7606b to 1d27c2d Compare November 30, 2023 16:46

kyrtapz changed the title ~~Bump github.com/openshift/api~~ NP-615: Bump github.com/openshift/api Dec 1, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 1, 2023

openshift-ci bot assigned mkowalski Dec 4, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023

kyrtapz and others added 2 commits December 5, 2023 13:21

Bump github.com/openshift/api

cd51b5b

go get github.com/openshift/api@master go mod tidy && go mod vendor Signed-off-by: Patryk Diak <pdiak@redhat.com>

kyrtapz force-pushed the bump_api branch from 1d27c2d to 6045ca4 Compare December 5, 2023 12:22

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023

openshift-ci bot assigned jcaamano Dec 5, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023

openshift-merge-bot bot merged commit 08960c0 into openshift:master Dec 6, 2023

Comments

Conversation

kyrtapz commented Nov 30, 2023

Uh oh!

kyrtapz commented Nov 30, 2023

Uh oh!

kyrtapz commented Dec 1, 2023

Uh oh!

kyrtapz commented Dec 1, 2023

Uh oh!

jcaamano commented Dec 1, 2023

Uh oh!

jcaamano commented Dec 1, 2023

Uh oh!

kyrtapz commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 1, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcaamano commented Dec 1, 2023

Uh oh!

kyrtapz commented Dec 4, 2023

Uh oh!

kyrtapz commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcaamano commented Dec 4, 2023

Uh oh!

kyrtapz commented Dec 4, 2023

Uh oh!

kyrtapz commented Dec 4, 2023

Uh oh!

mkowalski commented Dec 4, 2023

Uh oh!

mkowalski commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kyrtapz commented Dec 4, 2023

Uh oh!

jcaamano commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcaamano commented Dec 5, 2023

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

kyrtapz commented Dec 5, 2023

Uh oh!

kyrtapz commented Dec 5, 2023

Uh oh!

kyrtapz commented Dec 5, 2023

Uh oh!

kyrtapz commented Dec 5, 2023

Uh oh!

kyrtapz commented Dec 6, 2023

Uh oh!

kyrtapz commented Dec 6, 2023

Uh oh!

openshift-ci bot commented Dec 6, 2023

Uh oh!

kyrtapz commented Dec 6, 2023

Uh oh!

openshift-bot commented Dec 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kyrtapz commented Dec 1, 2023 •

edited

Loading

openshift-ci-robot commented Dec 1, 2023 •

edited by openshift-ci bot

Loading

kyrtapz commented Dec 4, 2023 •

edited

Loading

mkowalski commented Dec 4, 2023 •

edited

Loading

jcaamano commented Dec 4, 2023 •

edited

Loading