Skip to content

Comments

OPNET-414: Revert "Extend infra CR to store VIPs and MachineNetwork"#1694

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mkowalski:revert-1593-OPNET-351
Dec 5, 2023
Merged

OPNET-414: Revert "Extend infra CR to store VIPs and MachineNetwork"#1694
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mkowalski:revert-1593-OPNET-351

Conversation

@mkowalski
Copy link
Contributor

@mkowalski mkowalski commented Dec 4, 2023

Reverts #1593.

Due to long dependency chain for the pending implementation we decided the feature is not landing in 4.15 and is deferred till 4.16

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2023

@mkowalski: This pull request references OPNET-351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Reverts #1593

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

Hello @mkowalski! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 4, 2023
@openshift-ci openshift-ci bot requested review from jkyros and soltysh December 4, 2023 15:06
@mkowalski
Copy link
Contributor Author

/cc @JoelSpeed

@openshift-ci openshift-ci bot requested a review from JoelSpeed December 4, 2023 15:07
@JoelSpeed
Copy link
Contributor

Spoke with @mkowalski, this feature isn't going to land in 4.15 so we are going to revert the API and re-introduce it for 4.16 when we can hopefully land the feature.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f220962 and 2 for PR HEAD d4fd3d8 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2023

@mkowalski: This pull request references OPNET-351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Reverts #1593.

Due to long dependency chain for the pending implementation we decided the feature is not landing in 4.15 and is deferred till 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski mkowalski changed the title Revert "OPNET-351: Extend infra CR to store VIPs and MachineNetwork" OPNET-414: Revert "Extend infra CR to store VIPs and MachineNetwork" Dec 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2023

@mkowalski: This pull request references OPNET-414 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Reverts #1593.

Due to long dependency chain for the pending implementation we decided the feature is not landing in 4.15 and is deferred till 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2023

@mkowalski: This pull request references OPNET-414 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Contributor Author

/test e2e-aws-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bfea29e and 1 for PR HEAD d4fd3d8 in total

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-client-go
/override ci/prow/verify-crd-schema

These failures are expected on a revert

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-client-go, ci/prow/verify-crd-schema

Details

In response to this:

/override ci/prow/verify-client-go
/override ci/prow/verify-crd-schema

These failures are expected on a revert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp d4fd3d8 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202312051331.p0.gb5716b3.assembly.stream for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants