Skip to content

serviceMonitorKubeScheduler/serviceMonitorKubeControllerManager: enable TLS#316

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
s-urbaniak:secure-ctrl-sched
Apr 17, 2019
Merged

serviceMonitorKubeScheduler/serviceMonitorKubeControllerManager: enable TLS#316
openshift-merge-robot merged 2 commits into
openshift:masterfrom
s-urbaniak:secure-ctrl-sched

Conversation

@s-urbaniak

Copy link
Copy Markdown
Contributor

In accordance to
openshift/cluster-kube-scheduler-operator#88 and
openshift/cluster-kube-controller-manager-operator#207
we can now enable TLS for the kube scheduler as well the controller
manager.

This combines the two patches in one again.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2019
@s-urbaniak

Copy link
Copy Markdown
Contributor Author

xref openshift/origin#22516

@s-urbaniak

Copy link
Copy Markdown
Contributor Author

rechecked on a local cluster, locally port-forwarding the controller-manager/scheduler secure ports and using a local curl, everything works nicely, but pods on the cluster cannot reach the endpoints.

image

@s-urbaniak

Copy link
Copy Markdown
Contributor Author

It turns out, VPC security settings need an update: openshift/installer#1576

@s-urbaniak

Copy link
Copy Markdown
Contributor Author

@brancz PTAL

@brancz

brancz commented Apr 12, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak

Copy link
Copy Markdown
Contributor Author

verified this patch in conjunction with openshift/installer#1576 locally

image

@s-urbaniak

Copy link
Copy Markdown
Contributor Author

/test e2e-aws

1 similar comment
@s-urbaniak

Copy link
Copy Markdown
Contributor Author

/test e2e-aws

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@paulfantom

Copy link
Copy Markdown
Contributor

/retest

@paulfantom

Copy link
Copy Markdown
Contributor

/refresh
/retest

@paulfantom

Copy link
Copy Markdown
Contributor

/retest

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@paulfantom

Copy link
Copy Markdown
Contributor

/retest

5 similar comments
@paulfantom

Copy link
Copy Markdown
Contributor

/retest

@brancz

brancz commented Apr 17, 2019

Copy link
Copy Markdown
Contributor

/retest

@paulfantom

Copy link
Copy Markdown
Contributor

/retest

@s-urbaniak

Copy link
Copy Markdown
Contributor Author

/retest

@paulfantom

Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 724ca54 into openshift:master Apr 17, 2019
@s-urbaniak s-urbaniak deleted the secure-ctrl-sched branch April 18, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants