Disable insecure port#88
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Apr 8, 2019
Merged
Conversation
Contributor
Author
|
/assign @s-urbaniak |
openshift-ci-robot
added
size/XS
Contributor
Author
|
/assign @ravisantoshgudimetla |
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
|
just a small request from my side, I enabled a tls based servicemonitor locally, but the kube-scheduler endpoints seem to point to the wrong port: I believe these should rather be |
s-urbaniak
added a commit
to s-urbaniak/cluster-monitoring-operator
that referenced
this pull request
Apr 5, 2019
In accordance to openshift/cluster-kube-scheduler-operator#88 and openshift/cluster-kube-controller-manager-operator#207 we can now enable TLS for the kube scheduler as well the controller manager.
s-urbaniak
added a commit
to s-urbaniak/cluster-monitoring-operator
that referenced
this pull request
Apr 5, 2019
…le TLS In accordance to openshift/cluster-kube-scheduler-operator#88 and openshift/cluster-kube-controller-manager-operator#207 we can now enable TLS for the kube scheduler as well the controller manager.
sttts
force-pushed
the
sttts-insecure-port
branch
from
0c838c1 to
ed4a0c7
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
s-urbaniak
added a commit
to s-urbaniak/cluster-monitoring-operator
that referenced
this pull request
Apr 8, 2019
In accordance to openshift/cluster-kube-scheduler-operator#88 we can now enable TLS for the kube scheduler.
s-urbaniak
added a commit
to s-urbaniak/cluster-monitoring-operator
that referenced
this pull request
Apr 10, 2019
…le TLS In accordance to openshift/cluster-kube-scheduler-operator#88 and openshift/cluster-kube-controller-manager-operator#207 we can now enable TLS for the kube scheduler as well the controller manager.
s-urbaniak
added a commit
to s-urbaniak/installer
that referenced
this pull request
Apr 10, 2019
Recently, the control plane switched to secure ports in [1] and [2]. This aligns them in the installer. [1] openshift/cluster-kube-scheduler-operator#88 [2] openshift/cluster-kube-controller-manager-operator#207
s-urbaniak
added a commit
to s-urbaniak/cluster-monitoring-operator
that referenced
this pull request
Apr 12, 2019
…le TLS In accordance to openshift/cluster-kube-scheduler-operator#88 and openshift/cluster-kube-controller-manager-operator#207 we can now enable TLS for the kube scheduler as well the controller manager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocked by https://github.com/openshift/cluster-monitoring-operator/blob/172beb3e0d2cbf1f79bf61ba9c3f5bea373b4125/assets/prometheus-k8s/service-monitor-kube-scheduler.yaml#L15 pointing to the secure port.