Skip to content

e2e-tests: ensure pod assertions find at least one pod - #2028

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
sthaha:fix-pod-assertions
Jul 3, 2023
Merged

e2e-tests: ensure pod assertions find at least one pod#2028
openshift-merge-robot merged 1 commit into
openshift:masterfrom
sthaha:fix-pod-assertions

Conversation

@sthaha

@sthaha sthaha commented Jun 28, 2023

Copy link
Copy Markdown

No description provided.

@sthaha sthaha changed the title e2e-tests: ensure pod assertions finds atleast one pod e2e-tests: ensure pod assertions find at least one pod Jun 28, 2023
@openshift-ci
openshift-ci Bot requested review from marioferh and raptorsun June 28, 2023 21:03
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@sthaha

sthaha commented Jun 29, 2023

Copy link
Copy Markdown
Author

/retest-required

@sthaha sthaha mentioned this pull request Jun 29, 2023
Merged
@marioferh

marioferh commented Jun 29, 2023

Copy link
Copy Markdown
Contributor

/retest

@sthaha

sthaha commented Jun 29, 2023

Copy link
Copy Markdown
Author

/hold

Holding this until #2018 and #2011 are merged.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
marioferh
marioferh reviewed Jun 29, 2023
View reviewed changes

@marioferh marioferh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
simonpasquier
simonpasquier reviewed Jun 29, 2023
View reviewed changes
Comment thread test/e2e/framework/assertions.go Outdated
}

if len(pods.Items) == 0 {
return fmt.Errorf("%w - failed to find pods in %s matching %s", err, namespace, labelSelector)

@simonpasquier simonpasquier Jun 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err should be nil

Suggested change
return fmt.Errorf("%w - failed to find pods in %s matching %s", err, namespace, labelSelector)
return fmt.Errorf("failed to find pods in %s matching %s", namespace, labelSelector)

@sthaha sthaha Jul 3, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!!

@sthaha
sthaha force-pushed the fix-pod-assertions branch from abb5749 to 250cfae Compare July 3, 2023 02:32
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@sthaha
sthaha force-pushed the fix-pod-assertions branch from 250cfae to 18b5914 Compare July 3, 2023 03:01
@sthaha

sthaha commented Jul 3, 2023

Copy link
Copy Markdown
Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023
Sunil Thaha
e2e-tests: ensure pod assertions finds atleast one pod
cca89e0 
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@sthaha
sthaha force-pushed the fix-pod-assertions branch from 18b5914 to cca89e0 Compare July 3, 2023 05:49
@openshift-ci

openshift-ci Bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

@sthaha: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

simonpasquier
simonpasquier reviewed Jul 3, 2023
View reviewed changes

@simonpasquier simonpasquier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@openshift-ci

openshift-ci Bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, simonpasquier, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [marioferh,simonpasquier,sthaha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit d4fa84c into openshift:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonpasquier simonpasquier simonpasquier left review comments
@raptorsun raptorsun Awaiting requested review from raptorsun
+1 more reviewer
@marioferh marioferh marioferh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@simonpasquier simonpasquier

@marioferh marioferh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sthaha @marioferh @simonpasquier @openshift-merge-robot