OCPBUGS-14922: skip console-plugin installation if console CO is absent

[sthaha]

This PR fixes the failure to upgrade from OpenShift version 4.13 to 4.14 in environments (such as telco) where console ClusterOperator is disabled. The upgrade fails happens when CMO executes the console-plugin task which fails due to missing ConsolePlugin.

The fix checks for the presence of console ClusterOperator and bails out (with a log message) if it is absent.

[openshift-ci-robot]

@sthaha: This pull request references Jira Issue OCPBUGS-14922, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR fixes the failure to upgrade from OpenShift version 4.13 to 4.14 in environments (such as telco) where console ClusterOperator is disabled. The upgrade fails happens when CMO executes the console-plugin task which fails due to missing ConsolePlugin.

The fix checks for the presence of console ClusterOperator and bails out (with a log message) if it is absent.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jan--f]

/jira refresh

[openshift-ci-robot]

@jan--f: This pull request references Jira Issue OCPBUGS-14922, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[simonpasquier]

The handleEvent() function needs to react on changes to the clusterversion object.

cluster-monitoring-operator/pkg/operator/operator.go

Lines 568 to 596 in 8d67591

	if _, ok := obj.(*configv1.Infrastructure); ok {
	klog.Infof("Triggering update due to an infrastructure update")
	o.enqueue(cmoConfigMap)
	return
	}
	if _, ok := obj.(*configv1.APIServer); ok {
	klog.Infof("Triggering update due to an apiserver config update")
	o.enqueue(cmoConfigMap)
	return
	}
	if _, ok := obj.(*v1.PersistentVolumeClaim); ok {
	klog.Info("Triggering update due to a PVC update")
	o.enqueue(cmoConfigMap)
	return
	}
	if _, ok := obj.(*configv1.Console); ok {
	klog.Info("Triggering update due to a console update")
	o.enqueue(cmoConfigMap)
	return
	}
	if _, ok := obj.(*configv1.ClusterOperator); ok {
	klog.Info("Triggering update due to a cluster operator update")
	o.enqueue(cmoConfigMap)
	return
	}

I'd also replace the existing if blocks by type switches (e.g. https://go.dev/tour/methods/16).

[sthaha]

/retest-required

[sthaha]

/retest-required

[sthaha]

/retest-required

[openshift-ci]

@sthaha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	3aac627	link	false	/test e2e-aws-ovn-single-node
ci/prow/versions	3aac627	link	false	/test versions

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sthaha]

/retest-required

[jan--f]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jan--f,sthaha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sthaha: Jira Issue OCPBUGS-14922: All pull requests linked via external trackers have merged:

• openshift/cluster-monitoring-operator#2011

Jira Issue OCPBUGS-14922 has been moved to the MODIFIED state.

Details

In response to this:

This PR fixes the failure to upgrade from OpenShift version 4.13 to 4.14 in environments (such as telco) where console ClusterOperator is disabled. The upgrade fails happens when CMO executes the console-plugin task which fails due to missing ConsolePlugin.

The fix checks for the presence of console ClusterOperator and bails out (with a log message) if it is absent.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.