Skip to content

go.{mod,sum}: require Go 1.18#1769

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
simonpasquier:bump-go-version-in-gomod
Sep 14, 2022
Merged

go.{mod,sum}: require Go 1.18#1769
openshift-merge-robot merged 1 commit into
openshift:masterfrom
simonpasquier:bump-go-version-in-gomod

Conversation

@simonpasquier

Copy link
Copy Markdown
Contributor

This is consistent with the version used by the OCP build toolchain and avoids potential issues with go mod tidy.

Required for #1764

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This is consistent with the version used by the OCP build toolchain and
avoids potential issues with `go mod tidy`.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci openshift-ci Bot requested review from juanrh and sthaha September 14, 2022 09:03
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@simonpasquier

Copy link
Copy Markdown
Contributor Author

/skip

@jan--f

jan--f commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/label docs-approved
/label px-approved
/label qe-approved
Adding labels for a simple version bump.

@openshift-ci openshift-ci Bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Sep 14, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@openshift-ci

openshift-ci Bot commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD cf86818 and 2 for PR HEAD bbed315 in total

@simonpasquier

Copy link
Copy Markdown
Contributor Author

/skip

@openshift-ci

openshift-ci Bot commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node bbed315 link false /test e2e-aws-single-node
ci/prow/versions bbed315 link false /test versions

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3f83764 into openshift:master Sep 14, 2022
@simonpasquier simonpasquier deleted the bump-go-version-in-gomod branch September 21, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants