Skip to content

update to release.openshift.io/feature-set to match OCP 4.12#1764

Merged
openshift-ci[bot] merged 4 commits into
openshift:masterfrom
deads2k:update-api
Oct 10, 2022
Merged

update to release.openshift.io/feature-set to match OCP 4.12#1764
openshift-ci[bot] merged 4 commits into
openshift:masterfrom
deads2k:update-api

Conversation

@deads2k

@deads2k deads2k commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

This updates the operator openshift/api master to pick up the updated feature-set string. In so doing, it must bring in kube 1.25.0, which I've done. Minor fitting was required in a mock in order to build.

This was added in openshift/cluster-version-operator#821 to allow more featuresets and allow for a future migration to include actual gates. Because usage of this manifest would prevent upgrades, there are not upgrade concerns for this change.

/cc @wking

@openshift-ci openshift-ci Bot requested a review from wking September 8, 2022 21:07
@jan--f

jan--f commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

/retest

@deads2k

deads2k commented Sep 13, 2022

Copy link
Copy Markdown
Contributor Author

/retest

I think I got the generator problem, but I don't see how to fix the vendor job.

@jan--f

jan--f commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

/retest

I think I got the generator problem, but I don't see how to fix the vendor job.

Looks like we're running into pruning issues as outlined in https://go.dev/doc/go1.17#go-command.

We need to either change our Makefile to run go mod tidy -compat=1.17 or update our module to go1.18.
Updating seems reasonable to me, @simonpasquier mind chiming in here?

@simonpasquier simonpasquier mentioned this pull request Sep 14, 2022
2 tasks
@simonpasquier

Copy link
Copy Markdown
Contributor

We need to either change our Makefile to run go mod tidy -compat=1.17 or update our module to go1.18.

submitted #1769 to bump go.mod to go 1.18.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
@jan--f

jan--f commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

@deads2k after a rebase and make generate && make vendor this should be good to go.
/label docs-approved
/label px-approved
/label qe-approved
Adding labels for a version bump of api dependencies.

@openshift-ci openshift-ci Bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Sep 15, 2022
@deads2k

deads2k commented Oct 3, 2022

Copy link
Copy Markdown
Contributor Author

@deads2k after a rebase and make generate && make vendor this should be good to go.
/label docs-approved
/label px-approved
/label qe-approved
Adding labels for a version bump of api dependencies.

I keep getting

To upgrade to the versions selected by go 1.16, leaving some packages unresolved:
	go mod tidy -e -go=1.16 && go mod tidy -e -go=1.17
If reproducibility with go 1.16 is not needed:
	go mod tidy -compat=1.17
For other options, see:
	https://golang.org/doc/modules/pruning

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2022
@deads2k

deads2k commented Oct 10, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@simonpasquier

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@openshift-ci

openshift-ci Bot commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 08223fd and 2 for PR HEAD bddf0e1 in total

@openshift-ci

openshift-ci Bot commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants