Set API Version based on flag when discovery won't work#156
Set API Version based on flag when discovery won't work#156JoelSpeed wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demichev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold @Fedosin is working on an alternative to this |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close We will use #157 instead |
|
@JoelSpeed: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In openshift/machine-api-operator#992, we are introducing a new CRD which is in the machine.openshift.io/v1 group. This means that the server preferred version of the API is now
v1and notv1beta1. Because Machines don't yet exist in thev1` group, this means the CMA is currently broken on that PR.If we were to merge the PR we would break the CMA across openshift.
To mitigate this, we must allow the version to be set manually and only rely on discovery when the preferred version is not set via a flag.