Skip to content

Update OpenShift API to include placement groups #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 26, 2022
Merged

Update OpenShift API to include placement groups #992

openshift-merge-robot merged 2 commits into from
Feb 26, 2022

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Feb 11, 2022 •
edited
Loading

This PR updates the openshift/api repo dependency and installs the new AWSPlacementGroup CRD within clusters

This will only be able to merge once openshift/api#1091 has been merged

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2022
@JoelSpeed JoelSpeed changed the title [WIP][OCPCLOUD-Update OpenShift API to include placement groups [WIP] Update OpenShift API to include placement groups Feb 11, 2022
@JoelSpeed JoelSpeed force-pushed the placement-groups-crd branch from 30a0cd0 to 2082d0b Compare February 16, 2022 11:08
damdo
damdo reviewed Feb 16, 2022
View reviewed changes
Copy link
Member

@damdo damdo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mentioned it will need the canonical api import, but other than that it LGTM

alexander-demicev
alexander-demicev approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@JoelSpeed JoelSpeed force-pushed the placement-groups-crd branch from 2082d0b to ff9d02a Compare February 21, 2022 14:24
@JoelSpeed JoelSpeed changed the title [WIP] Update OpenShift API to include placement groups Update OpenShift API to include placement groups Feb 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2022
@JoelSpeed JoelSpeed force-pushed the placement-groups-crd branch from ff9d02a to ed8fb34 Compare February 22, 2022 10:37
@damdo
Copy link
Member

damdo commented Feb 22, 2022

I see the api change to the canonical openshift/api has merged and is now referenced.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

damdo added a commit to damdo/machine-api-provider-aws that referenced this pull request Feb 22, 2022
@damdo
temp: cherry-pick of openshift/machine-api-operator/pull/992
3defed7
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@damdo
Copy link
Member

damdo commented Feb 22, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

24 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2022 •
edited
Loading

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt ed8fb34 link false /test e2e-libvirt
ci/prow/e2e-vsphere ed8fb34 link false /test e2e-vsphere
ci/prow/e2e-metal-ipi-virtualmedia ed8fb34 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-openstack ed8fb34 link false /test e2e-openstack
ci/prow/e2e-gcp ed8fb34 link false /test e2e-gcp
ci/prow/e2e-metal-ipi-upgrade ed8fb34 link false /test e2e-metal-ipi-upgrade
ci/prow/e2e-vsphere-operator ed8fb34 link false /test e2e-vsphere-operator
ci/prow/e2e-metal-ipi ed8fb34 link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-ipv6 ed8fb34 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-azure ed8fb34 link false /test e2e-azure
ci/prow/e2e-azure-operator ed8fb34 link false /test e2e-azure-operator
ci/prow/e2e-gcp-operator ed8fb34 link false /test e2e-gcp-operator
ci/prow/e2e-aws-operator-tech-preview ed8fb34 link false /test e2e-aws-operator-tech-preview
ci/prow/e2e-aws-disruptive ed8fb34 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack ed8fb34 link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d2800dc into openshift:master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@lobziik lobziik Awaiting requested review from lobziik

@SamuelStuchly SamuelStuchly Awaiting requested review from SamuelStuchly

+1 more reviewer

@alexander-demicev alexander-demicev alexander-demicev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoelSpeed @damdo @openshift-bot @alexander-demicev @openshift-merge-robot