Skip to content

Bump(*) dependencies#75

Closed
ravisantoshgudimetla wants to merge 1 commit intoopenshift:masterfrom
ravisantoshgudimetla:bump-clientgo
Closed

Bump(*) dependencies#75
ravisantoshgudimetla wants to merge 1 commit intoopenshift:masterfrom
ravisantoshgudimetla:bump-clientgo

Conversation

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ravisantoshgudimetla]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 20, 2019
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

@damemi - We need to check if we need changes you mentioned in #74 and if this bump is going to fail without the changes in 8416646

@openshift-ci-robot
Copy link
Copy Markdown

@ravisantoshgudimetla: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 389ff01 link /test e2e-aws
ci/prow/e2e-aws-serial 389ff01 link /test e2e-aws-serial
ci/prow/e2e-aws-operator 389ff01 link /test e2e-aws-operator
ci/prow/images 389ff01 link /test images
ci/prow/unit 389ff01 link /test unit
ci/prow/verify 389ff01 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@damemi
Copy link
Copy Markdown
Contributor

damemi commented Mar 20, 2019

@ravisantoshgudimetla without that change I couldn't get this to compile, as you can see from the CI errors. But I'm also still unable to get CI to pass in #74 so there could be some other problems, if you want this PR to overtake that one I'm not opposed

@sjenning
Copy link
Copy Markdown
Contributor

@ravisantoshgudimetla if still needed, this will need rebase on #74

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

@sjenning - I think, this supersedes the changes in #74, so I need to get this working anyways.

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

/close

@openshift-ci-robot
Copy link
Copy Markdown

@ravisantoshgudimetla: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants