Skip to content

bug 2037665: Check policy name field independently of the configmap change#403

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
ingvagabund:check-policy-name-field-independent-of-cm-changes
Jan 25, 2022
Merged

bug 2037665: Check policy name field independently of the configmap change#403
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
ingvagabund:check-policy-name-field-independent-of-cm-changes

Conversation

@ingvagabund
Copy link
Copy Markdown
Member

From the logs:

I0125 06:13:50.166765       1 status_controller.go:211] clusteroperator/kube-scheduler diff {"status":{"conditions":[{"lastTransitionTime":"2022-01-25T05:43:31Z","message":"NodeControllerDegraded: All master nodes are ready","reason":"AsExpected","status":"False","type":"Degraded"},{"lastTransitionTime":"2022-01-25T06:13:50Z","message":"NodeInstallerProgressing: 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"NodeInstaller","status":"True","type":"Progressing"},{"lastTransitionTime":"2022-01-25T05:45:45Z","message":"StaticPodsAvailable: 3 nodes are active; 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"AsExpected","status":"True","type":"Available"},{"lastTransitionTime":"2022-01-25T06:13:42Z","message":"PolicyUpgradeable: deprecated scheduler.policy field is set, and it is to be removed in the next release","reason":"Policy_PolicyFieldSpecified","status":"False","type":"Upgradeable"}]}}
...
I0125 06:13:50.953915       1 event.go:282] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-kube-scheduler-operator", Name:"openshift-kube-scheduler-operator", UID:"825f8035-2ba7-4136-bb5a-88d64e25298e", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ConfigMapCreated' Created ConfigMap/config-10 -n openshift-kube-scheduler because it was missing
I0125 06:13:51.366266       1 status_controller.go:211] clusteroperator/kube-scheduler diff {"status":{"conditions":[{"lastTransitionTime":"2022-01-25T05:43:31Z","message":"NodeControllerDegraded: All master nodes are ready","reason":"AsExpected","status":"False","type":"Degraded"},{"lastTransitionTime":"2022-01-25T06:13:50Z","message":"NodeInstallerProgressing: 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"NodeInstaller","status":"True","type":"Progressing"},{"lastTransitionTime":"2022-01-25T05:45:45Z","message":"StaticPodsAvailable: 3 nodes are active; 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"AsExpected","status":"True","type":"Available"},{"lastTransitionTime":"2022-01-25T06:13:51Z","message":"All is well","reason":"AsExpected","status":"True","type":"Upgradeable"}]}}

The current deprecatedPolicy condition depends on whether the kube-scheduler-pod CM was updated or not.
Which is unrelated to whether the policy.name field is set or not.
Causing the PolicyUpgradeable condition to be cleared (deprecatedPolicy
to be unset) when the CM is not updated.

@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 25, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 25, 2022

@ingvagabund: This pull request references Bugzilla bug 2037665, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2033751 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2033751 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @kasturinarra

Details

In response to this:

bug 2037665: Check policy name field independently of the configmap change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
From the logs:
```
I0125 06:13:50.166765       1 status_controller.go:211] clusteroperator/kube-scheduler diff {"status":{"conditions":[{"lastTransitionTime":"2022-01-25T05:43:31Z","message":"NodeControllerDegraded: All master nodes are ready","reason":"AsExpected","status":"False","type":"Degraded"},{"lastTransitionTime":"2022-01-25T06:13:50Z","message":"NodeInstallerProgressing: 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"NodeInstaller","status":"True","type":"Progressing"},{"lastTransitionTime":"2022-01-25T05:45:45Z","message":"StaticPodsAvailable: 3 nodes are active; 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"AsExpected","status":"True","type":"Available"},{"lastTransitionTime":"2022-01-25T06:13:42Z","message":"PolicyUpgradeable: deprecated scheduler.policy field is set, and it is to be removed in the next release","reason":"Policy_PolicyFieldSpecified","status":"False","type":"Upgradeable"}]}}
...
I0125 06:13:50.953915       1 event.go:282] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-kube-scheduler-operator", Name:"openshift-kube-scheduler-operator", UID:"825f8035-2ba7-4136-bb5a-88d64e25298e", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ConfigMapCreated' Created ConfigMap/config-10 -n openshift-kube-scheduler because it was missing
I0125 06:13:51.366266       1 status_controller.go:211] clusteroperator/kube-scheduler diff {"status":{"conditions":[{"lastTransitionTime":"2022-01-25T05:43:31Z","message":"NodeControllerDegraded: All master nodes are ready","reason":"AsExpected","status":"False","type":"Degraded"},{"lastTransitionTime":"2022-01-25T06:13:50Z","message":"NodeInstallerProgressing: 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"NodeInstaller","status":"True","type":"Progressing"},{"lastTransitionTime":"2022-01-25T05:45:45Z","message":"StaticPodsAvailable: 3 nodes are active; 3 nodes are at revision 8; 0 nodes have achieved new revision 9","reason":"AsExpected","status":"True","type":"Available"},{"lastTransitionTime":"2022-01-25T06:13:51Z","message":"All is well","reason":"AsExpected","status":"True","type":"Upgradeable"}]}}
```

The current deprecatedPolicy condition depends on whether the kube-scheduler-pod CM was updated or not.
Which is unrelated to whether the policy.name field is set or not.
Causing the PolicyUpgradeable condition to be cleared (deprecatedPolicy
to be unset) when the CM is not updated.
@ingvagabund ingvagabund force-pushed the check-policy-name-field-independent-of-cm-changes branch from f032041 to 2f01603 Compare January 25, 2022 11:20
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ingvagabund,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 25, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 25, 2022
@kasturinarra
Copy link
Copy Markdown

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 25, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 25, 2022

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8b44299 into openshift:release-4.9 Jan 25, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 25, 2022

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 2037665 has been moved to the MODIFIED state.

Details

In response to this:

bug 2037665: Check policy name field independently of the configmap change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the check-policy-name-field-independent-of-cm-changes branch January 25, 2022 13:27
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Feb 1, 2022
Following up on 430e536 (A prerequsite for 4.9 to 4.10 upgrades has
been identified, 2022-01-20, openshift#1401), now that 4.9.19 has been named,
includes [1], and [2] has been VERIFIED.

[1]: openshift/cluster-kube-scheduler-operator#403
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=2037665
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Feb 1, 2022
Following up on 430e536 (A prerequsite for 4.9 to 4.10 upgrades has
been identified, 2022-01-20, openshift#1401), now that 4.9.19 has been named,
includes [1], and [2] has been VERIFIED.

[1]: openshift/cluster-kube-scheduler-operator#403
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=2037665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants