Skip to content

bug 2037665: Set upgradeable=false if using Policy field#400

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.9from
ingvagabund:391
Jan 20, 2022
Merged

bug 2037665: Set upgradeable=false if using Policy field#400
openshift-merge-robot merged 2 commits intoopenshift:release-4.9from
ingvagabund:391

Conversation

@ingvagabund
Copy link
Copy Markdown
Member

@ingvagabund ingvagabund commented Jan 19, 2022

To prevent upgrades from breaking due to Policy being removed in 4.10 (see #390)

Building on top of #391

@ingvagabund ingvagabund mentioned this pull request Jan 19, 2022
Closed
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 19, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 19, 2022

@ingvagabund: This pull request references Bugzilla bug 2037665, which is invalid:

  • expected dependent Bugzilla bug 2033751 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

bug 2037665: Set upgradeable=false if using Policy field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from soltysh and sttts January 19, 2022 10:18
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@wallylewis
Copy link
Copy Markdown

wallylewis commented Jan 19, 2022

/retest

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Jan 19, 2022

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 19, 2022

@ingvagabund: This pull request references Bugzilla bug 2037665, which is invalid:

  • expected dependent Bugzilla bug 2033751 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 20, 2022

Overriding the valid-bug label, since we need that to block 4.10 upgrades

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@soltysh soltysh added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed lgtm Indicates that a PR is ready to be merged. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 20, 2022
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 20, 2022

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 20, 2022

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 20, 2022

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 20, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ingvagabund,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@kasturinarra
Copy link
Copy Markdown

kasturinarra commented Jan 20, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8858cea into openshift:release-4.9 Jan 20, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 20, 2022

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 2037665 has been moved to the MODIFIED state.

Details

In response to this:

bug 2037665: Set upgradeable=false if using Policy field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the 391 branch January 20, 2022 16:06
@ingvagabund ingvagabund mentioned this pull request Jan 24, 2022
Merged
@openshift-ci openshift-ci Bot mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ingvagabund @wallylewis @soltysh @kasturinarra @openshift-merge-robot @damemi