bug 1889488: [e2e]: kube_pod_resource_requests renamed to kube_pod_container_resource_requests#323
Conversation
ingvagabund
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
@ingvagabund: This pull request references Bugzilla bug 1889488, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references Bugzilla bug 1889488, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damemi FYI |
| "scheduler_schedule_attempts_total", // returned by /metrics | ||
| "kube_pod_resource_request", // returned by /metrics/resources | ||
| "scheduler_schedule_attempts_total", // returned by /metrics | ||
| "kube_pod_container_resource_requests", // returned by /metrics/resources |
There was a problem hiding this comment.
/hold
The change is wrong based on https://github.com/openshift/kubernetes/blob/master/pkg/scheduler/metrics/resources/resources.go#L54
openshift-ci-robot
added
the
do-not-merge/hold
|
Yeah, this is not correct. |
|
/close |
|
@ingvagabund: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references Bugzilla bug 1889488. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund was there a resolution to what was wrong with this test? I don't remember when we were talking about it |
|
Yeah, just wait for #319 to merge and have the changes propagated to the installer. |
5 participants
Related: #322