Skip to content

Bug 1891068: manifests: add missing profile annotations#319

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sjenning:add-profile-annotations
Jan 14, 2021
Merged

Bug 1891068: manifests: add missing profile annotations#319
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sjenning:add-profile-annotations

Conversation

@sjenning
Copy link
Copy Markdown
Contributor

@sjenning sjenning commented Jan 12, 2021

@smarterclayton @wking @fabiand

#283 added a resource without profile annotations.

openshift/oc#663 will prevent this from happening again.

In fact, it was the CI run on this PR that caught this
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_oc/663/pull-ci-openshift-oc-master-images/1349103979241410560/build-log.txt

wking
wking approved these changes Jan 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@sjenning sjenning force-pushed the add-profile-annotations branch from 054537a to 844cefb Compare January 12, 2021 21:56
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@sjenning sjenning mentioned this pull request Jan 12, 2021
Closed
@sjenning sjenning force-pushed the add-profile-annotations branch from 844cefb to 30b22df Compare January 12, 2021 22:04
wking
wking approved these changes Jan 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@wking
Copy link
Copy Markdown
Member

wking commented Jan 12, 2021

Would be good to redo whatever analysis went into #185, about what needs internal-openshift-hosted exclusion. But we're punting on that here to unblock CI, where we see kube-scheduler TargetDown failures because of the missing self-managed-high-availability profile this is fixing. internal-openshift-hosted should be re-visited in a follow-up PR, if anything needs adjusting there.

@wking
Copy link
Copy Markdown
Member

wking commented Jan 12, 2021

/retitle Bug 1891068: manifests: add missing profile annotations

@openshift-ci-robot openshift-ci-robot changed the title manifests: add missing profile annotations Bug 1891068: manifests: add missing profile annotations Jan 12, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 12, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 12, 2021

@sjenning: This pull request references Bugzilla bug 1891068, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1891068: manifests: add missing profile annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 12, 2021
@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented Jan 12, 2021

/retest

1 similar comment
@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented Jan 13, 2021

/retest

@wking
Copy link
Copy Markdown
Member

wking commented Jan 13, 2021

Hrm, still seeing the scheduler TargetDown in the e2e-aws job. Checking the CVO logs:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-scheduler-operator/319/pull-ci-openshift-cluster-kube-scheduler-operator-master-e2e-aws/1349127266201767936/artifacts/e2e-aws/gather-extra/pods/openshift-cluster-version_cluster-version-operator-588998db77-6dwg8_cluster-version-operator.log | grep -o 'Running sync for .*\(scheduler-operator\|prometheus-k8s-scheduler-resources\).*' | sort | uniq
Running sync for clusterrole "prometheus-k8s-scheduler-resources" (630 of 660)
Running sync for clusterrolebinding "system:openshift:operator:cluster-kube-scheduler-operator" (114 of 660)
Running sync for configmap "openshift-kube-scheduler-operator/openshift-kube-scheduler-operator-config" (113 of 660)
Running sync for deployment "openshift-kube-scheduler-operator/openshift-kube-scheduler-operator" (116 of 660)
Running sync for namespace "openshift-kube-scheduler-operator" (109 of 660)
Running sync for prometheusrule "openshift-kube-scheduler-operator/kube-scheduler-operator" (629 of 660)
Running sync for role "openshift-kube-scheduler-operator/prometheus-k8s" (626 of 660)
Running sync for rolebinding "openshift-kube-scheduler-operator/prometheus-k8s" (627 of 660)
Running sync for service "openshift-kube-scheduler-operator/metrics" (112 of 660)
Running sync for serviceaccount "openshift-kube-scheduler-operator/openshift-kube-scheduler-operator" (115 of 660)
Running sync for servicemonitor "openshift-kube-scheduler-operator/kube-scheduler-operator" (628 of 660)

So we have the manifest we're trying to add, but still see similar scheduler behavior?

@sjenning sjenning force-pushed the add-profile-annotations branch from 30b22df to be37ef9 Compare January 13, 2021 19:36
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@wking
Copy link
Copy Markdown
Member

wking commented Jan 13, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
damemi
damemi approved these changes Jan 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, sjenning, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented Jan 13, 2021

/test e2e-aws-operator

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3482ab7 into openshift:master Jan 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 14, 2021

@sjenning: All pull requests linked via external trackers have merged:

Bugzilla bug 1891068 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1891068: manifests: add missing profile annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

2 more reviewers

@wking wking wking approved these changes

@damemi damemi damemi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sjenning @wking @openshift-ci-robot @openshift-bot @damemi @openshift-merge-robot