OCPBUGS-63213: Add priority field to prevent early shutdown

[CoreyCook8]

Based on the issue described here : kubernetes/kubernetes#133442

priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.

To prevent this we must set priority explicitly

[openshift-ci]

Hi @CoreyCook8. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[CoreyCook8]

👋 @ingvagabund could I get an ok-to-test on this so we can merge when the E2E test PR merges in? 🙏

[CoreyCook8]

👋 @ingvagabund could I get an ok-to-test on this so we can merge when the E2E test PR merges in? 🙏

@ingvagabund @deads2k ping on this 🙏

[ingvagabund]

/ok-to-test

[ingvagabund]

/approve
/lgtm

[ingvagabund]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoreyCook8, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ingvagabund]

/verified by ci/prow/e2e-aws-operator

The operator needs to see the mirrored pod up and running. The KA admission plugin will fail when the priority class number is different from what is normally defined.

[openshift-ci-robot]

@ingvagabund: This PR has been marked as verified by ci/prow/e2e-aws-operator.

Details

In response to this:

/verified by ci/prow/e2e-aws-operator

The operator needs to see the mirrored pod up and running. The KA admission plugin will fail when the priority class number is different from what is normally defined.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ingvagabund]

/re-title no-jira: Add priority field to prevent early shutdown

[ingvagabund]

/retitle no-jira: Add priority field to prevent early shutdown

[openshift-ci-robot]

@CoreyCook8: This pull request explicitly references no jira issue.

Details

In response to this:

Based on the issue described here : kubernetes/kubernetes#133442

priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.

To prevent this we must set priority explicitly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 310bd06 and 2 for PR HEAD a8fd579 in total

[openshift-ci]

@CoreyCook8: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dinhxuanvu]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@dinhxuanvu: new pull request created: #890

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sanchezl]

/retitle OCPBUGS-63213: Add priority field to prevent early shutdown

[openshift-ci-robot]

@CoreyCook8: Jira Issue Verification Checks: Jira Issue OCPBUGS-63213
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63213 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Based on the issue described here : kubernetes/kubernetes#133442

priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.

To prevent this we must set priority explicitly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.