OCPBUGS-63213: Add priority field to prevent early shutdown

[CoreyCook8]

Based on the issue described here : kubernetes/kubernetes#133442

priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.

To prevent this we must set priority explicitly

[openshift-ci]

Hi @CoreyCook8. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tjungblu]

/ok-to-test

[tjungblu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoreyCook8, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tjungblu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tjungblu]

/retest-required

[tjungblu]

/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-aws-ovn-etcd-scaling
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-cpms
/override ci/prow/e2e-agnostic-ovn

[openshift-ci]

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-agnostic-ovn, ci/prow/e2e-aws-cpms, ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-metal-assisted

Details

In response to this:

/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-aws-ovn-etcd-scaling
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-cpms
/override ci/prow/e2e-agnostic-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@CoreyCook8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ovn-two-node-fencing	fd02f1b	link	false	/test e2e-metal-ovn-two-node-fencing
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown	fd02f1b	link	false	/test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-azure-ovn-etcd-scaling	fd02f1b	link	false	/test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-azure	fd02f1b	link	false	/test e2e-azure
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown	fd02f1b	link	false	/test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws	fd02f1b	link	false	/test e2e-aws
ci/prow/e2e-aws-etcd-recovery	fd02f1b	link	false	/test e2e-aws-etcd-recovery
ci/prow/e2e-aws-etcd-certrotation	fd02f1b	link	false	/test e2e-aws-etcd-certrotation
ci/prow/e2e-gcp-disruptive	fd02f1b	link	false	/test e2e-gcp-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling	fd02f1b	link	false	/test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling	fd02f1b	link	false	/test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive	fd02f1b	link	false	/test e2e-aws-disruptive
ci/prow/e2e-aws-disruptive-ovn	fd02f1b	link	false	/test e2e-aws-disruptive-ovn
ci/prow/e2e-gcp-disruptive-ovn	fd02f1b	link	false	/test e2e-gcp-disruptive-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tjungblu]

/label acknowledge-critical-fixes-only

[tjungblu]

/retitle NO-JIRA: Add priority field to prevent early shutdown

[openshift-ci-robot]

@CoreyCook8: This pull request explicitly references no jira issue.

Details

In response to this:

Based on the issue described here : kubernetes/kubernetes#133442

priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.

To prevent this we must set priority explicitly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tjungblu]

/verified by @tjungblu

spun up a clusterbot with this PR, got the priority set just right:

[openshift-ci-robot]

@tjungblu: This PR has been marked as verified by @tjungblu.

Details

In response to this:

/verified by @tjungblu

spun up a clusterbot with this PR, got the priority set just right:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zcollins0]

Hey @tjungblu , we have 3 other PRs open doing basically the same thing for other static pods. Can we get a review on those as well? openshift/cluster-kube-scheduler-operator#572, openshift/cluster-kube-apiserver-operator#1915, openshift/cluster-kube-controller-manager-operator#865

[dinhxuanvu]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@dinhxuanvu: new pull request created: #1508

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sanchezl]

/retitle OCPBUGS-63213: Add priority field to prevent early shutdown

[openshift-ci-robot]

@CoreyCook8: Jira Issue OCPBUGS-63213 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

Based on the issue described here : kubernetes/kubernetes#133442

priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.

To prevent this we must set priority explicitly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sanchezl]

/jira refresh

[openshift-ci-robot]

@sanchezl: Jira Issue Verification Checks: Jira Issue OCPBUGS-63213
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63213 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.