Skip to content

Bump openshift/api#542

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Elbehery:bump-openshift-api
Jul 9, 2021
Merged

Bump openshift/api#542
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Elbehery:bump-openshift-api

Conversation

@Elbehery
Copy link
Contributor

@Elbehery Elbehery commented Jun 30, 2021

This will allow us to get latest feature gates about CSI migration

Note: this is needed for CSI migration feature to work in OCP 4.9.
Goal of this PR is to apply --feature-gate= CSIMigrationGCE=true, CSIMigrationAzureDisk=true to kubelet when TechPreviewNoUpgrade featureSet is enabled, which was introduced in openshift/api#957

@Elbehery
Copy link
Contributor Author

Elbehery commented Jun 30, 2021

/assign @bertinatto
/assign @jsafrane

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh June 30, 2021 18:58
@Elbehery Elbehery force-pushed the bump-openshift-api branch 2 times, most recently from 47a3e05 to d2b137b Compare July 1, 2021 14:03
@Elbehery
Copy link
Contributor Author

Elbehery commented Jul 1, 2021

/retest

@Elbehery Elbehery force-pushed the bump-openshift-api branch from d2b137b to 0f83a27 Compare July 2, 2021 10:42
@jsafrane
Copy link
Contributor

jsafrane commented Jul 2, 2021

The flakes look unrelated
/retest

@soltysh
Copy link
Contributor

soltysh commented Jul 2, 2021

Closing in favor of #450 which bumps both api and library-go.
/close

@openshift-ci openshift-ci bot closed this Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@soltysh: Closed this PR.

Details

In response to this:

Closing in favor of #450 which bumps both api and library-go.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery
Copy link
Contributor Author

Elbehery commented Jul 8, 2021

@bertinatto @soltysh the bumped version of openshift/api in #450 is earlier than the version we need here :)

@Elbehery
Copy link
Contributor Author

Elbehery commented Jul 8, 2021

/reopen

@openshift-ci openshift-ci bot reopened this Jul 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2021

@Elbehery: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2021
@Elbehery
Bump openshift/api
be8a24e 
The goal of this bump is to apply `CSIMigrationGCE` and `CSIMigrationAzureDisk`
feature gates to kubelet config when the `TechPreviewNoUpgrade` featureSet is
set by the user.
@Elbehery Elbehery force-pushed the bump-openshift-api branch from 0f83a27 to be8a24e Compare July 8, 2021 15:58
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2021
@Elbehery
Copy link
Contributor Author

Elbehery commented Jul 8, 2021

@bertinatto @soltysh can I get lgtm here please 🙏🏽

ravisantoshgudimetla
ravisantoshgudimetla approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@Elbehery
Copy link
Contributor Author

Elbehery commented Jul 8, 2021

/assign @damemi

soltysh
soltysh approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, ravisantoshgudimetla, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6738c73 into openshift:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

2 more reviewers

@soltysh soltysh soltysh approved these changes

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@bertinatto bertinatto

@jsafrane jsafrane

@damemi damemi

@ravisantoshgudimetla ravisantoshgudimetla

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Elbehery @jsafrane @soltysh @ravisantoshgudimetla @bertinatto @damemi @openshift-merge-robot